Skip to content

Commit d467085

Browse files
📝 CodeRabbit Chat: Add detailed PR content file for Go 1.24 and UBI 9 upgrades in CI configs
1 parent 3e7c7e1 commit d467085

File tree

1 file changed

+100
-23
lines changed

1 file changed

+100
-23
lines changed

GO_VERSION_UPDATE_REMINDER.md

Lines changed: 100 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,108 @@
1-
# Go 1.24 Upgrade - Step 6 Action Required
1+
# Go 1.24 Upgrade - Ready-to-Use PR Content for openshift/release
22

3-
## Action Required: Update openshift/release Repository
3+
## Files to Update in openshift/release Repository
44

5-
Per DEPENDENCIES.md step 6, you need to manually update the Go version in the openshift/release repository:
5+
### 1. Main Branch Configuration
6+
**File**: `ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-main.yaml`
67

7-
### Files to Update
8-
1. **Main branch config**:
9-
- File: `ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-main.yaml`
10-
- Line: ~10 (go version specification)
11-
- Change: Update Go version from current version to 1.24
8+
**Change needed:**
9+
```yaml
10+
build_root:
11+
image_stream_tag:
12+
name: release
13+
namespace: openshift
14+
tag: golang-1.24 # Update from golang-1.23
15+
```
1216
13-
2. **v1.10-branch config**:
14-
- File: `ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-v1.10-branch.yaml`
15-
- Line: ~10 (go version specification)
16-
- Change: Update Go version from current version to 1.24
17+
**And:**
18+
```yaml
19+
base_images:
20+
ubi_minimal:
21+
name: ubi-minimal
22+
namespace: ocp
23+
tag: "9" # Update from "8"
24+
```
1725
18-
### Steps
19-
1. Fork/clone the openshift/release repository
20-
2. Update the Go version in both configuration files
21-
3. Create a PR in the openshift/release repository
22-
4. Follow openshift/release PR guidelines for CI configuration changes
26+
### 2. v1.10-branch Configuration
27+
**File**: `ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-v1.10-branch.yaml`
2328

24-
### Repository
25-
<https://github.com/openshift/release>
29+
**Same changes as above:**
30+
- Update `build_root.image_stream_tag.tag` from `golang-1.23` to `golang-1.24`
31+
- Update `base_images.ubi_minimal.tag` from `"8"` to `"9"`
2632

27-
### Current PR Context
28-
This Go 1.24 upgrade PR in opendatahub-io/kubeflow requires corresponding CI configuration updates in openshift/release.
33+
## Ready-to-Use PR Description for openshift/release
2934

30-
### Note
31-
This step cannot be automated as it requires changes to an external repository (openshift/release) where this automation doesn't have write access.
35+
```markdown
36+
# Update Go version to 1.24 for opendatahub-io/kubeflow
37+
38+
This PR updates the CI configuration for opendatahub-io/kubeflow to use Go 1.24 and UBI 9.
39+
40+
## Changes
41+
- Update `golang-1.23` to `golang-1.24` in build_root image_stream_tag
42+
- Update UBI minimal base image from tag "8" to "9"
43+
44+
## Files Modified
45+
- `ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-main.yaml`
46+
- `ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-v1.10-branch.yaml`
47+
48+
## Context
49+
This change supports the Go 1.24 upgrade in opendatahub-io/kubeflow repository (PR #657).
50+
51+
## Testing
52+
- [ ] CI configuration validates successfully
53+
- [ ] Build jobs use correct Go version
54+
- [ ] UBI 9 base images are available
55+
```
56+
57+
## Quick Commands to Create the PR
58+
59+
1. **Fork and clone openshift/release:**
60+
```bash
61+
gh repo fork openshift/release --clone
62+
cd release
63+
git checkout -b update-kubeflow-go-1.24
64+
```
65+
66+
2. **Make the changes:**
67+
```bash
68+
# Update main branch config
69+
sed -i 's/golang-1.23/golang-1.24/g' ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-main.yaml
70+
sed -i 's/tag: "8"/tag: "9"/g' ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-main.yaml
71+
72+
# Update v1.10-branch config
73+
sed -i 's/golang-1.23/golang-1.24/g' ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-v1.10-branch.yaml
74+
sed -i 's/tag: "8"/tag: "9"/g' ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-v1.10-branch.yaml
75+
```
76+
77+
3. **Commit and push:**
78+
```bash
79+
git add .
80+
git commit -m "Update Go version to 1.24 for opendatahub-io/kubeflow"
81+
git push origin update-kubeflow-go-1.24
82+
```
83+
84+
4. **Create PR:**
85+
```bash
86+
gh pr create --title "Update Go version to 1.24 for opendatahub-io/kubeflow" --body "$(cat <<'EOL'
87+
This PR updates the CI configuration for opendatahub-io/kubeflow to use Go 1.24 and UBI 9.
88+
89+
## Changes
90+
- Update golang-1.23 to golang-1.24 in build_root image_stream_tag
91+
- Update UBI minimal base image from tag "8" to "9"
92+
93+
## Files Modified
94+
- ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-main.yaml
95+
- ci-operator/config/opendatahub-io/kubeflow/opendatahub-io-kubeflow-v1.10-branch.yaml
96+
97+
## Context
98+
This change supports the Go 1.24 upgrade in opendatahub-io/kubeflow repository.
99+
EOL
100+
)"
101+
```bash
102+
103+
## Repository Links
104+
- **openshift/release**: https://github.com/openshift/release
105+
- **Current kubeflow PR**: https://github.com/opendatahub-io/kubeflow/pull/657
106+
107+
---
108+
*This file now contains actionable steps instead of just reminders.*

0 commit comments

Comments
 (0)