Skip to content

Commit f67a2e7

Browse files
committed
Update the logger names in odh-notebook-controller tests
We used the very same logger names for both the odh-notebook-controller and the notebook-webhook components which could make it harder to distinguish what component logged what.
1 parent 1970a67 commit f67a2e7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

components/odh-notebook-controller/controllers/suite_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ var _ = BeforeSuite(func() {
187187
// Setup notebook controller
188188
err = (&OpenshiftNotebookReconciler{
189189
Client: mgr.GetClient(),
190-
Log: ctrl.Log.WithName("controllers").WithName("notebook-controller"),
190+
Log: ctrl.Log.WithName("controllers").WithName("odh-notebook-controller"),
191191
Scheme: mgr.GetScheme(),
192192
Namespace: odhNotebookControllerTestNamespace,
193193
Config: mgr.GetConfig(),
@@ -198,7 +198,7 @@ var _ = BeforeSuite(func() {
198198
hookServer := mgr.GetWebhookServer()
199199
notebookWebhook := &webhook.Admission{
200200
Handler: &NotebookWebhook{
201-
Log: ctrl.Log.WithName("controllers").WithName("notebook-controller"),
201+
Log: ctrl.Log.WithName("controllers").WithName("odh-notebook-webhook"),
202202
Client: mgr.GetClient(),
203203
Config: mgr.GetConfig(),
204204
Namespace: odhNotebookControllerTestNamespace,

0 commit comments

Comments
 (0)