forked from kubeflow/kubeflow
-
Notifications
You must be signed in to change notification settings - Fork 45
Open
Description
Description
There's a discrepancy between the informational message and the actual find
commands used in ci/kustomize.sh
.
Issue Details
- Line 71 states:
echo "Starting to run kustomize '${kustomize_version}' for each kustomization.yaml file except components"
- Line 73 has a comment:
# We don't want to execute kustomization on the components part as it's not intended to be used that way.
- However, lines 76 and 79 (
find . -name "kustomization.yaml" ...
) process allkustomization.yaml
files found in the current directory and its subdirectories, without actually excluding anycomponents
directory.
Current Behavior vs Expected
The script currently processes ALL kustomization.yaml files, but the message and comments suggest it should exclude components.
Lines 75 and 78 show commented-out versions that DO exclude components using grep -v "components"
:
- Line 75:
# find . -name "kustomization.yaml" | xargs dirname | grep -v "components" | xargs -I {} "${kustomize_bin}" build {} >"${kustomize_stdout}" 2>"${kustomize_stderr}"
- Line 78:
# find . -name "kustomization.yaml" | xargs dirname | grep -v "components" | xargs --verbose -I {} "${kustomize_bin}" build {} >/dev/null
Possible Solutions
Either:
- Update the
find
commands to actually exclude components (uncomment and use lines 75, 78) - Update the informational message on line 71 to reflect that all kustomization.yaml files are processed
References
Metadata
Metadata
Assignees
Labels
No labels