Skip to content

Commit 41be615

Browse files
authored
chore: Ensure consistent version of generate proto stubs (#58)
Ensure the versions of the generated protobuf code stubs are consistent with the versions as specified in the Dockerfile and the go.mo file. - protoc v3.21.5 - protoc-gen-go v1.28.1 - protoc-gen-go-grpc v1.3.0 Signed-off-by: Christian Kadner <[email protected]>
1 parent ad03d9a commit 41be615

16 files changed

+294
-136
lines changed

Dockerfile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,13 @@ WORKDIR /opt/app
7777
COPY go.mod go.sum ./
7878

7979
# Install go protoc plugins
80+
# no required module provides package google.golang.org/grpc/cmd/protoc-gen-go-grpc
81+
# to add it run `go get google.golang.org/grpc/cmd/protoc-gen-go-grpc`
8082
ENV PATH $HOME/go/bin:$PATH
81-
RUN go get google.golang.org/protobuf/cmd/protoc-gen-go \
82-
google.golang.org/grpc/cmd/protoc-gen-go-grpc \
83+
RUN true \
84+
&& go get google.golang.org/grpc/cmd/protoc-gen-go-grpc \
85+
&& go install google.golang.org/protobuf/cmd/protoc-gen-go \
86+
google.golang.org/grpc/cmd/protoc-gen-go-grpc \
8387
&& protoc-gen-go --version \
8488
&& true
8589

internal/proto/kfserving-predict-v2/inference.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/proto/kfserving-predict-v2/inference_grpc.pb.go

Lines changed: 23 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/proto/mlserver/dataplane/dataplane.pb.go

Lines changed: 17 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)