fix: Incorrect conversion between integer types (#69)

Add function `GetEnvInt32` using `strconv.ParseInt` when `int32` is expected

---------

Signed-off-by: Rafael Vasquez <[email protected]>

Author: rafvasq

internal/envconfig/envconfig.go

@@ -4,7 +4,7 @@
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
-//     http://www.apache.org/licenses/LICENSE-2.0
+//	http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ -46,6 +46,18 @@ func GetEnvInt(key string, defaultValue int, log logr.Logger) int {
 	return defaultValue
 }
 
+func GetEnvInt32(key string, defaultValue int32, log logr.Logger) int32 {
+	if strVal, found := os.LookupEnv(key); found {
+		val, err := strconv.ParseInt(strVal, 10, 32)
+		if err != nil {
+			log.Error(err, "Environment variable must be of type int32", "env_var", key, "value", strVal)
+			os.Exit(1)
+		}
+		return int32(val)
+	}
+	return defaultValue
+}
+
 func GetEnvFloat(key string, defaultValue float64, log logr.Logger) float64 {
 	if strVal, found := os.LookupEnv(key); found {
 		val, err := strconv.ParseFloat(strVal, 64)

model-mesh-torchserve-adapter/server/config.go

@@ -4,7 +4,7 @@
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
-//     http://www.apache.org/licenses/LICENSE-2.0
+//	http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ -81,8 +81,8 @@ func GetAdapterConfigurationFromEnv(log logr.Logger) (*AdapterConfiguration, err
 		return nil, fmt.Errorf("Could not construct torchserve model store path: %w", err)
 	}
 
-	adapterConfig.RequestBatchSize = int32(GetEnvInt(requestBatchSize, defaultRequestBatchSize, log))
-	adapterConfig.MaxBatchDelaySecs = int32(GetEnvInt(maxBatchDelaySecs, defaultMaxBatchDelaySecs, log))
+	adapterConfig.RequestBatchSize = GetEnvInt32(requestBatchSize, defaultRequestBatchSize, log)
+	adapterConfig.MaxBatchDelaySecs = GetEnvInt32(maxBatchDelaySecs, defaultMaxBatchDelaySecs, log)
 
 	if adapterConfig.TorchServeContainerMemReqBytes < 0 {
 		return nil, fmt.Errorf("%s environment variable must be set to a positive integer, found value %v",