ci: use a smarter check for uncommitted files (#612)

This is stolen from a recent kubeflow PR by @ederign. Compared to the previous version, this also reports on new untracked files. Also, the command is much simpler to read.

Author: jiridanek

.github/workflows/code-quality.yaml

@@ -19,17 +19,15 @@ jobs:
 
       - name: Check there aren't any modified files present
         run: |
-          if [[ $(git ls-files . -d -m -o --exclude-standard --full-name -v | tee modified.log | wc -l) -gt 0 ]]; then
-            echo "There are changed files"
-            exit 1
+          clean=$(git status --porcelain)
+          if [[ -z "$clean" ]]; then
+              echo "Empty git status --porcelain: $clean"
+          else
+              echo "Uncommitted file changes detected: $clean"
+              git diff
+              exit 1
           fi
 
-      - name: Print modified files
-        if: ${{ failure() }}
-        run: |
-          cat modified.log
-          git diff
-
   code-static-analysis:
     runs-on: ubuntu-latest
     steps: