Skip to content

Commit 205388b

Browse files
Merge pull request #611 from jstourac/ownersUpdate
Update OWNERS file with adding more approvers
2 parents fecd10c + 6da0818 commit 205388b

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,8 @@ Pull requests are the best way to propose changes to the notebooks repository:
5656
### Testing your PR locally
5757
5858
- Test the changes locally, by manually running the `$make jupyter-${NOTEBOOK_NAME}-ubi8-python-3.8` from the terminal. This definitely helps in that initial phase.
59+
60+
### Review and Merge Process
61+
62+
- Once the PR is submitted, you can either select specific reviewers or let the bot to select reviewers [automatically](https://prow.ci.openshift.org/plugins?repo=opendatahub-io%2Fnotebooks).
63+
- For the PR to be merged, it must receive 2 reviews from the repository [approvals/reviewers](/OWNERS). Following that, an `/approve` comment must be added by someone with approval rights. If the author of the PR has approval rights, it is preferred that they perform the merge action.

OWNERS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
approvers:
22
- atheo89
3+
- caponetto
34
- harshad16
5+
- jiridanek
6+
- jstourac
7+
- paulovmr
48

59
reviewers:
610
- atheo89

0 commit comments

Comments
 (0)