Skip to content

Commit 2b7c581

Browse files
committed
add IDs to GitHub Actions build steps and update condition for Playwright tests to run every time a codeserver image is built (#2356)
1 parent ae2c4c3 commit 2b7c581

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/build-notebooks-TEMPLATE.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@ jobs:
308308
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
309309

310310
- name: "push|schedule|workflow_dispatch: make ${{ inputs.target }}"
311+
id: push-make-target
311312
run: |
312313
# print running stats on disk occupancy
313314
(while true; do df -h | grep "${HOME}/.local/share/containers"; sleep 30; done) &
@@ -320,6 +321,7 @@ jobs:
320321
IMAGE_TAG: "${{ steps.calculated_vars.outputs.IMAGE_TAG }}"
321322
CONTAINER_BUILD_CACHE_ARGS: "${{ steps.extra-podman-build-args.outputs.EXTRA_PODMAN_BUILD_ARGS }} --cache-from ${{ env.CACHE }} --cache-to ${{ env.CACHE }}"
322323
- name: "pull_request: make ${{ inputs.target }}"
324+
id: pr-make-target
323325
run: |
324326
# print running stats on disk occupancy
325327
(while true; do df -h | grep "${HOME}/.local/share/containers"; sleep 30; done) &
@@ -687,7 +689,7 @@ jobs:
687689
# we leave little free disk space after we mount LVM for podman storage
688690
# not enough to install playwright; running playwright in podman uses the space we have
689691
- name: Run Playwright tests
690-
if: ${{ contains(inputs.target, 'codeserver') }}
692+
if: ${{ !cancelled() && contains(inputs.target, 'codeserver') && (steps.push-make-target.outcome == 'success' || steps.pr-make-target.outcome == 'success') }}
691693
# --ipc=host because Microsoft says so in Playwright docs
692694
# --net=host because testcontainers connects to the Reaper container's exposed port
693695
# we need to pass through the relevant environment variables

0 commit comments

Comments
 (0)