Skip to content

Commit 3f93529

Browse files
authored
Merge pull request #596 from harshad16/chore-amd
chores: Fix the makefile for amd calls and upgrade odh-elyra
2 parents c2c87a9 + 02f9de3 commit 3f93529

File tree

6 files changed

+91
-36
lines changed

6 files changed

+91
-36
lines changed

.github/workflows/build-notebooks.yaml

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -444,6 +444,61 @@
444444
},
445445
"secrets": "inherit"
446446
},
447+
"amd-c9s-python-3_9": {
448+
"needs": [
449+
"base-c9s-python-3_9"
450+
],
451+
"uses": "./.github/workflows/build-notebooks-TEMPLATE.yaml",
452+
"with": {
453+
"target": "amd-c9s-python-3.9",
454+
"github": "${{ toJSON(github) }}"
455+
},
456+
"secrets": "inherit"
457+
},
458+
"amd-jupyter-minimal-c9s-python-3_9": {
459+
"needs": [
460+
"amd-c9s-python-3_9"
461+
],
462+
"uses": "./.github/workflows/build-notebooks-TEMPLATE.yaml",
463+
"with": {
464+
"target": "amd-jupyter-minimal-c9s-python-3.9",
465+
"github": "${{ toJSON(github) }}"
466+
},
467+
"secrets": "inherit"
468+
},
469+
"amd-jupyter-datascience-c9s-python-3_9": {
470+
"needs": [
471+
"amd-jupyter-minimal-c9s-python-3_9"
472+
],
473+
"uses": "./.github/workflows/build-notebooks-TEMPLATE.yaml",
474+
"with": {
475+
"target": "amd-jupyter-datascience-c9s-python-3.9",
476+
"github": "${{ toJSON(github) }}"
477+
},
478+
"secrets": "inherit"
479+
},
480+
"amd-jupyter-tensorflow-c9s-python-3_9": {
481+
"needs": [
482+
"amd-jupyter-datascience-c9s-python-3_9"
483+
],
484+
"uses": "./.github/workflows/build-notebooks-TEMPLATE.yaml",
485+
"with": {
486+
"target": "amd-jupyter-tensorflow-c9s-python-3.9",
487+
"github": "${{ toJSON(github) }}"
488+
},
489+
"secrets": "inherit"
490+
},
491+
"amd-jupyter-pytorch-c9s-python-3_9": {
492+
"needs": [
493+
"amd-jupyter-datascience-c9s-python-3_9"
494+
],
495+
"uses": "./.github/workflows/build-notebooks-TEMPLATE.yaml",
496+
"with": {
497+
"target": "amd-jupyter-pytorch-c9s-python-3.9",
498+
"github": "${{ toJSON(github) }}"
499+
},
500+
"secrets": "inherit"
501+
},
447502
"base-anaconda-python-3_8": {
448503
"needs": [],
449504
"uses": "./.github/workflows/build-notebooks-TEMPLATE.yaml",

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -274,16 +274,16 @@ amd-c9s-python-3.9: base-c9s-python-3.9
274274

275275
# We are only using c9s base image here onwards,
276276
# DON'T confuse due to the ubi9 mention, it just directory name.
277-
.PHONY: amd-minimal-c9s-python-3.9
278-
amd-minimal-c9s-python-3.9: amd-c9s-python-3.9
277+
.PHONY: amd-jupyter-minimal-c9s-python-3.9
278+
amd-jupyter-minimal-c9s-python-3.9: amd-c9s-python-3.9
279279
$(call image,$@,jupyter/minimal/ubi9-python-3.9,$<)
280280

281-
# Build and push cuda-jupyter-datascience-ubi9-python-3.9 image to the registry
281+
# Build and push jupyter-datascience-ubi9-python-3.9 image to the registry
282282
.PHONY: amd-jupyter-datascience-c9s-python-3.9
283-
amd-jupyter-datascience-c9s-python-3.9: amd-jupyter-minimal-ubi9-python-3.9
283+
amd-jupyter-datascience-c9s-python-3.9: amd-jupyter-minimal-c9s-python-3.9
284284
$(call image,$@,jupyter/datascience/ubi9-python-3.9,$<)
285285

286-
# Build and push cuda-jupyter-tensorflow-ubi9-python-3.9 image to the registry
286+
# Build and push jupyter-tensorflow-ubi9-python-3.9 image to the registry
287287
.PHONY: amd-jupyter-tensorflow-c9s-python-3.9
288288
amd-jupyter-tensorflow-c9s-python-3.9: amd-jupyter-datascience-c9s-python-3.9
289289
$(call image,$@,jupyter/amd/tensorflow/ubi9-python-3.9,$<)

jupyter/amd/pytorch/ubi9-python-3.9/Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ pyodbc = "~=5.1.0"
3737
mysql-connector-python = "~=8.3.0"
3838

3939
# JupyterLab packages
40-
odh-elyra = "~=3.16.5"
40+
odh-elyra = "~=3.16.7"
4141
jupyterlab = "~=3.6.7" # Wait on upgrade till plugins are ready
4242
jupyter-bokeh = "~=3.0.7" # Upgrade would bring in jupyterlab 4
4343
jupyter-server = "~=2.13.0"

jupyter/amd/pytorch/ubi9-python-3.9/Pipfile.lock

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jupyter/amd/tensorflow/ubi9-python-3.9/Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ pyodbc = "~=5.1.0"
3838
mysql-connector-python = "~=8.3.0"
3939

4040
# JupyterLab packages
41-
odh-elyra = "~=3.16.5"
41+
odh-elyra = "~=3.16.7"
4242
kfp = "~=2.5.0"
4343
kfp-kubernetes = "~=1.0.0"
4444

jupyter/amd/tensorflow/ubi9-python-3.9/Pipfile.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)