Skip to content

Commit 4dacb93

Browse files
authored
#2178: fix(ci): add dependency versions pins in build-notebooks workflow (#2183)
1 parent 62fb1f7 commit 4dacb93

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

.github/workflows/build-notebooks-TEMPLATE.yaml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -384,21 +384,25 @@ jobs:
384384
385385
# https://github.com/cri-o/packaging?tab=readme-ov-file#distributions-using-deb-packages
386386
387-
curl -fsSL https://pkgs.k8s.io/core:/stable:/$KUBERNETES_VERSION/deb/Release.key | \
387+
curl -fsSL https://pkgs.k8s.io/core:/stable:/v${KUBERNETES_VERSION}/deb/Release.key | \
388388
sudo gpg --dearmor --batch --yes -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg
389389
390-
echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/$KUBERNETES_VERSION/deb/ /" | \
390+
echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v${KUBERNETES_VERSION}/deb/ /" | \
391391
sudo tee /etc/apt/sources.list.d/kubernetes.list
392392
393-
curl -fsSL https://download.opensuse.org/repositories/isv:/cri-o:/stable:/$CRIO_VERSION/deb/Release.key | \
393+
curl -fsSL https://download.opensuse.org/repositories/isv:/cri-o:/stable:/v${CRIO_VERSION}/deb/Release.key | \
394394
sudo gpg --dearmor --batch --yes -o /etc/apt/keyrings/cri-o-apt-keyring.gpg
395395
396-
echo "deb [signed-by=/etc/apt/keyrings/cri-o-apt-keyring.gpg] https://download.opensuse.org/repositories/isv:/cri-o:/stable:/$CRIO_VERSION/deb/ /" | \
396+
echo "deb [signed-by=/etc/apt/keyrings/cri-o-apt-keyring.gpg] https://download.opensuse.org/repositories/isv:/cri-o:/stable:/v${CRIO_VERSION}/deb/ /" | \
397397
sudo tee /etc/apt/sources.list.d/cri-o.list
398398
399399
sudo apt-get update
400400
# [ERROR FileExisting-conntrack]: conntrack not found in system path
401-
sudo apt-get install -y cri-o cri-tools kubelet kubeadm kubectl conntrack
401+
# see man apt-patterns for the ~name=version* syntax
402+
sudo apt-get install -y \
403+
"cri-o=${CRIO_VERSION}.*" \
404+
"kubelet=${KUBERNETES_VERSION}.*" "kubeadm=${KUBERNETES_VERSION}.*" "kubectl=${KUBERNETES_VERSION}.*" \
405+
conntrack
402406
403407
# make use of /etc/cni/net.d/11-crio-ipv4-bridge.conflist so we don't
404408
# need a pod network and just use the default bridge
@@ -412,12 +416,13 @@ jobs:
412416
413417
sudo systemctl start crio.service
414418
env:
415-
CRIO_VERSION: v1.32
419+
# TODO(jdanek): install also "cri-tools=${CRIO_VERSION}.*" when updating to 1.33
420+
CRIO_VERSION: 1.32
416421
# This has to be kept in sync with the packages above, otherwise
417422
# [ERROR KubeletVersion]: the kubelet version is higher than the control plane version.
418423
# This is not a supported version skew and may lead to a malfunctional cluster.
419424
# Kubelet version: "1.33.0" Control plane version: "1.30.12"
420-
KUBERNETES_VERSION: v1.33
425+
KUBERNETES_VERSION: 1.33
421426

422427
- name: Show crio debug data (on failure)
423428
if: ${{ failure() && steps.have-tests.outputs.tests == 'true' }}

0 commit comments

Comments
 (0)