#1271: fix(scripts): posix noncompliance in nginx/root/usr/share/container-scripts/nginx/common.sh and duplicates of thereof (#1628)

* fix(nginx/common.sh) fix shell script that was not POSIX-complaint

Let's rather add the `#!/usr/bin/env bash` and just use bash

---------

Co-authored-by: Jiri Daněk <[email protected]>

Author: satnam72

codeserver/ubi9-python-3.12/nginx/root/usr/share/container-scripts/nginx/common.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 # get_matched_files finds file for image extending
 function get_matched_files() {
@@ -17,15 +17,15 @@ function process_extending_files() {
   local custom_dir default_dir
   custom_dir=$1
   default_dir=$2
-  while read filename ; do
-    if [ $filename ]; then
+  while read -r filename ; do
+    if [ "$filename" ]; then
       echo "=> sourcing $filename ..."
-      # Custom file is prefered
-      if [ -f $custom_dir/$filename ]; then
-        source $custom_dir/$filename
-      elif [ -f $default_dir/$filename ]; then 
-        source $default_dir/$filename
+      # custom file has precedence
+      if [ -f "$custom_dir/$filename" ]; then
+        source "$custom_dir/$filename"
+      elif [ -f "$default_dir/$filename" ]; then
+        source "$default_dir/$filename"
       fi
     fi
   done <<<"$(get_matched_files "$custom_dir" "$default_dir" '*.sh' | sort -u)"
-}
+}

rstudio/c9s-python-3.11/nginx/root/usr/share/container-scripts/nginx/common.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 # get_matched_files finds file for image extending
 function get_matched_files() {
@@ -17,15 +17,15 @@ function process_extending_files() {
   local custom_dir default_dir
   custom_dir=$1
   default_dir=$2
-  while read filename ; do
-    if [ $filename ]; then
+  while read -r filename ; do
+    if [ "$filename" ]; then
       echo "=> sourcing $filename ..."
-      # Custom file is prefered
-      if [ -f $custom_dir/$filename ]; then
-        source $custom_dir/$filename
-      elif [ -f $default_dir/$filename ]; then 
-        source $default_dir/$filename
+      # custom file has precedence
+      if [ -f "$custom_dir/$filename" ]; then
+        source "$custom_dir/$filename"
+      elif [ -f "$default_dir/$filename" ]; then
+        source "$default_dir/$filename"
       fi
     fi
   done <<<"$(get_matched_files "$custom_dir" "$default_dir" '*.sh' | sort -u)"
-}
+}

rstudio/rhel9-python-3.11/nginx/root/usr/share/container-scripts/nginx/common.sh

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 
 # get_matched_files finds file for image extending
 function get_matched_files() {
@@ -17,15 +17,15 @@ function process_extending_files() {
   local custom_dir default_dir
   custom_dir=$1
   default_dir=$2
-  while read filename ; do
-    if [ $filename ]; then
+  while read -r filename ; do
+    if [ "$filename" ]; then
       echo "=> sourcing $filename ..."
-      # Custom file is prefered
-      if [ -f $custom_dir/$filename ]; then
-        source $custom_dir/$filename
-      elif [ -f $default_dir/$filename ]; then 
-        source $default_dir/$filename
+      # custom file has precedence
+      if [ -f "$custom_dir/$filename" ]; then
+        source "$custom_dir/$filename"
+      elif [ -f "$default_dir/$filename" ]; then
+        source "$default_dir/$filename"
       fi
     fi
   done <<<"$(get_matched_files "$custom_dir" "$default_dir" '*.sh' | sort -u)"
-}
+}

tests/test_main.py

@@ -321,11 +321,17 @@ def test_files_that_should_be_same_are_same(subtests: pytest_subtests.plugin.Sub
         "ROCm de-vendor script": [
             PROJECT_ROOT / "jupyter/rocm/pytorch/ubi9-python-3.12/de-vendor-torch.sh",
             PROJECT_ROOT / "runtimes/rocm-pytorch/ubi9-python-3.12/de-vendor-torch.sh",
-        ]
+        ],
+        "nginx/common.sh": [
+            PROJECT_ROOT / "codeserver/ubi9-python-3.12/nginx/root/usr/share/container-scripts/nginx/common.sh",
+            PROJECT_ROOT / "rstudio/c9s-python-3.11/nginx/root/usr/share/container-scripts/nginx/common.sh",
+            PROJECT_ROOT / "rstudio/rhel9-python-3.11/nginx/root/usr/share/container-scripts/nginx/common.sh",
+        ],
     }
     for group_name, (first_file, *rest) in file_groups.items():
         with subtests.test(msg=f"Checking {group_name}"):
             for file in rest:
+                # file.write_text(first_file.read_text())  # update rest according to first
                 assert first_file.read_text() == file.read_text(), f"The files {first_file} and {file} do not match"