Skip to content

Commit 96d1b31

Browse files
committed
Fix the validation ci check with latest changes
Signed-off-by: Harshad Reddy Nalla <[email protected]>
1 parent 13dbeb3 commit 96d1b31

File tree

1 file changed

+39
-42
lines changed

1 file changed

+39
-42
lines changed

ci/check-params-env.sh

Lines changed: 39 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -91,114 +91,111 @@ function check_image_variable_matches_name_and_commitref() {
9191
local expected_build_name # Why some of the images has `-amd64` suffix and others not?
9292
case "${image_variable}" in
9393
odh-minimal-notebook-image-n)
94-
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
95-
expected_commitref="2024a"
96-
expected_build_name="jupyter-minimal-ubi9-python-3.9-amd64"
94+
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
95+
expected_commitref="2024b"
96+
expected_build_name="jupyter-minimal-ubi9-python-3.11-amd64"
9797
;;
9898
odh-minimal-notebook-image-n-1)
9999
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
100-
expected_commitref="2023b"
100+
expected_commitref="2024a"
101101
expected_build_name="jupyter-minimal-ubi9-python-3.9-amd64"
102102
;;
103103
odh-minimal-gpu-notebook-image-n)
104-
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
105-
expected_commitref="2024a"
106-
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.9-amd64"
104+
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
105+
expected_commitref="2024b"
106+
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.11-amd64"
107107
;;
108108
odh-minimal-gpu-notebook-image-n-1)
109109
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
110-
expected_commitref="2023b"
110+
expected_commitref="2024a"
111111
expected_build_name="cuda-jupyter-minimal-ubi9-python-3.9-amd64"
112112
;;
113113
odh-pytorch-gpu-notebook-image-n)
114-
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.9"
115-
expected_commitref="2024a"
116-
expected_build_name="jupyter-pytorch-ubi9-python-3.9-amd64"
114+
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.11"
115+
expected_commitref="2024b"
116+
expected_build_name="jupyter-pytorch-ubi9-python-3.11-amd64"
117117
;;
118118
odh-pytorch-gpu-notebook-image-n-1)
119119
expected_name="odh-notebook-jupyter-pytorch-ubi9-python-3.9"
120-
expected_commitref="2023b"
120+
expected_commitref="2024a"
121121
expected_build_name="jupyter-pytorch-ubi9-python-3.9-amd64"
122122
;;
123123
odh-generic-data-science-notebook-image-n)
124-
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.9"
125-
expected_commitref="2024a"
126-
expected_build_name="jupyter-datascience-ubi9-python-3.9-amd64"
124+
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.11"
125+
expected_commitref="2024b"
126+
expected_build_name="jupyter-datascience-ubi9-python-3.11-amd64"
127127
;;
128128
odh-generic-data-science-notebook-image-n-1)
129129
expected_name="odh-notebook-jupyter-datascience-ubi9-python-3.9"
130-
expected_commitref="2023b"
130+
expected_commitref="2024a"
131131
expected_build_name="jupyter-datascience-ubi9-python-3.9-amd64"
132132
;;
133133
odh-tensorflow-gpu-notebook-image-n)
134-
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.9"
135-
expected_commitref="2024a"
136-
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.9-amd64"
134+
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.11"
135+
expected_commitref="2024b"
136+
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.11-amd64"
137137
;;
138138
odh-tensorflow-gpu-notebook-image-n-1)
139139
expected_name="odh-notebook-cuda-jupyter-tensorflow-ubi9-python-3.9"
140-
expected_commitref="2023b"
140+
expected_commitref="2024a"
141141
expected_build_name="cuda-jupyter-tensorflow-ubi9-python-3.9-amd64"
142142
;;
143143
odh-trustyai-notebook-image-n)
144-
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.9"
145-
expected_commitref="2024a"
146-
expected_build_name="jupyter-trustyai-ubi9-python-3.9-amd64"
144+
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.11"
145+
expected_commitref="2024b"
146+
expected_build_name="jupyter-trustyai-ubi9-python-3.11-amd64"
147147
;;
148148
odh-trustyai-notebook-image-n-1)
149149
expected_name="odh-notebook-jupyter-trustyai-ubi9-python-3.9"
150-
expected_commitref="2023b"
150+
expected_commitref="2024a"
151151
expected_build_name="jupyter-trustyai-ubi9-python-3.9-amd64"
152152
;;
153153
odh-codeserver-notebook-image-n)
154-
expected_name="odh-notebook-code-server-ubi9-python-3.9"
155-
expected_commitref="2024a"
156-
expected_build_name="codeserver-ubi9-python-3.9-amd64"
154+
expected_name="odh-notebook-code-server-ubi9-python-3.11"
155+
expected_commitref="2024b"
156+
expected_build_name="codeserver-ubi9-python-3.11-amd64"
157157
;;
158158
odh-codeserver-notebook-image-n-1)
159159
expected_name="odh-notebook-code-server-ubi9-python-3.9"
160-
expected_commitref="2023b"
160+
expected_commitref="2024a"
161161
expected_build_name="codeserver-ubi9-python-3.9-amd64"
162162
;;
163163
odh-rstudio-notebook-image-n)
164-
expected_name="odh-notebook-rstudio-server-c9s-python-3.9"
165-
expected_commitref="2024a"
166-
expected_build_name="rstudio-c9s-python-3.9-amd64"
164+
expected_name="odh-notebook-rstudio-server-c9s-python-3.11"
165+
expected_commitref="2024b"
166+
expected_build_name="rstudio-c9s-python-3.11-amd64"
167167
;;
168168
odh-rstudio-notebook-image-n-1)
169169
expected_name="odh-notebook-rstudio-server-c9s-python-3.9"
170-
expected_commitref="2023b"
170+
expected_commitref="2024a"
171171
expected_build_name="rstudio-c9s-python-3.9-amd64"
172172
;;
173173
# For both RStudio GPU workbenches - the final name labels are identical to plain RStudio ones
174174
# This is because the very same RStudio Dockerfile is used but different base images in both cases
175175
# We should consider what to do with this - in ideal case, we should have different labels for these cases.
176176
odh-rstudio-gpu-notebook-image-n)
177-
expected_name="odh-notebook-rstudio-server-c9s-python-3.9"
178-
expected_commitref="2024a"
179-
expected_build_name="cuda-rstudio-c9s-python-3.9-amd64"
177+
expected_name="odh-notebook-rstudio-server-c9s-python-3.11"
178+
expected_commitref="2024b"
179+
expected_build_name="cuda-rstudio-c9s-python-3.11-amd64"
180180
;;
181181
odh-rstudio-gpu-notebook-image-n-1)
182182
expected_name="odh-notebook-rstudio-server-c9s-python-3.9"
183-
expected_commitref="2023b"
183+
expected_commitref="2024a"
184184
expected_build_name="cuda-rstudio-c9s-python-3.9-amd64"
185185
;;
186186
odh-rocm-minimal-notebook-image-n)
187187
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11"
188-
expected_commitref="main"
189-
# expected_commitref="2024b"
188+
expected_commitref="2024b"
190189
expected_build_name="rocm-jupyter-minimal-ubi9-python-3.11-amd64"
191190
;;
192191
odh-rocm-pytorch-notebook-image-n)
193192
expected_name="odh-notebook-jupyter-rocm-pytorch-ubi9-python-3.11"
194-
expected_commitref="main"
195-
# expected_commitref="2024b"
193+
expected_commitref="2024b"
196194
expected_build_name="rocm-jupyter-pytorch-ubi9-python-3.11-amd64"
197195
;;
198196
odh-rocm-tensorflow-notebook-image-n)
199197
expected_name="odh-notebook-jupyter-rocm-tensorflow-ubi9-python-3.11"
200-
expected_commitref="main"
201-
# expected_commitref="2024b"
198+
expected_commitref="2024b"
202199
expected_build_name="rocm-jupyter-tensorflow-ubi9-python-3.11-amd64"
203200
;;
204201
*)

0 commit comments

Comments
 (0)