Skip to content

Commit 9ef9e68

Browse files
committed
RHAIENG-287: fix(Dockerfiles): use separate export to avoid Hadolint SC2155 warning
``` ./runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu:214 SC2155 warning: Declare and assign separately to avoid masking return values. ```
1 parent 11ced62 commit 9ef9e68

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

jupyter/datascience/ubi9-python-3.12/Dockerfile.cpu

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@ if [ "${TARGETARCH}" = "ppc64le" ]; then
198198
git checkout ${ONNX_VERSION}
199199
git submodule update --init --recursive
200200
pip install -r requirements.txt
201-
export CMAKE_ARGS="-DPython3_EXECUTABLE=$(which python3.12)"
201+
CMAKE_ARGS="-DPython3_EXECUTABLE=$(which python3.12)"
202+
export CMAKE_ARGS
202203
pip wheel . -w /root/onnx_wheel
203204
else
204205
echo "Skipping ONNX build on non-Power"

runtimes/datascience/ubi9-python-3.12/Dockerfile.cpu

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,8 @@ RUN if [ "$TARGETARCH" = "ppc64le" ]; then \
226226
cd onnx && git checkout v${ONNX_VERSION} && \
227227
git submodule update --init --recursive && \
228228
pip install -r requirements.txt && \
229-
export CMAKE_ARGS="-DPython3_EXECUTABLE=$(which python3.12)" && \
229+
CMAKE_ARGS="-DPython3_EXECUTABLE=$(which python3.12)" && \
230+
export CMAKE_ARGS && \
230231
pip wheel . -w /onnx_wheels; \
231232
else \
232233
echo "Not ppc64le, skipping ONNX build" && mkdir -p /onnx_wheels; \
@@ -249,8 +250,10 @@ RUN if [ "$TARGETARCH" = "ppc64le" ]; then \
249250
git clone -b apache-arrow-${PYARROW_VERSION} https://github.com/apache/arrow.git --recursive && \
250251
cd arrow && rm -rf .git && mkdir dist && \
251252
pip3 install -r python/requirements-build.txt && \
252-
export ARROW_HOME=$(pwd)/dist && \
253-
export LD_LIBRARY_PATH=$(pwd)/dist/lib:$LD_LIBRARY_PATH && \
253+
ARROW_HOME=$(pwd)/dist && \
254+
export ARROW_HOME && \
255+
LD_LIBRARY_PATH=$(pwd)/dist/lib:$LD_LIBRARY_PATH && \
256+
export LD_LIBRARY_PATH && \
254257
export CMAKE_PREFIX_PATH=$ARROW_HOME:$CMAKE_PREFIX_PATH && \
255258
export PARQUET_TEST_DATA="${PWD}/cpp/submodules/parquet-testing/data" && \
256259
export ARROW_TEST_DATA="${PWD}/testing/data" && \

0 commit comments

Comments
 (0)