Skip to content

Commit b1748de

Browse files
dibryantdibryant
committed
Updated image manifests with AMD images for pytorch and tensorflow
1 parent 1db71cc commit b1748de

8 files changed

+133
-1
lines changed

‎ci/check-params-env.sh‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ PARAMS_ENV_PATH="manifests/base/params.env"
2525

2626
# This value needs to be updated everytime we deliberately change number of the
2727
# images we want to have in the `params.env` file.
28-
EXPECTED_NUM_RECORDS=20
28+
EXPECTED_NUM_RECORDS=23
2929

3030
# ---------------------------- DEFINED FUNCTIONS ----------------------------- #
3131

@@ -193,6 +193,21 @@ function check_image_variable_matches_name_and_commitref() {
193193
expected_commitref="2023b"
194194
expected_build_name="cuda-rstudio-c9s-python-3.9-amd64"
195195
;;
196+
odh-rocm-minimal-notebook-image-n)
197+
expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.9"
198+
expected_commitref="2024a"
199+
expected_build_name="rocm-jupyter-minimal-ubi9-python-3.9-amd64"
200+
;;
201+
odh-rocm-pytorch-notebook-image-n)
202+
expected_name="odh-notebook-jupyter-rocm-pytorch-ubi9-python-3.9"
203+
expected_commitref="2024a"
204+
expected_build_name="rocm-jupyter-pytorch-ubi9-python-3.9-amd64"
205+
;;
206+
odh-rocm-tensorflow-notebook-image-n)
207+
expected_name="odh-notebook-jupyter-rocm-tensorflow-ubi9-python-3.9"
208+
expected_commitref="2024a"
209+
expected_build_name="rocm-jupyter-tensorflow-ubi9-python-3.9-amd64"
210+
;;
196211
*)
197212
echo "Unimplemented variable name: '${image_variable}'"
198213
return 1

‎manifests/base/commit.env‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,6 @@ odh-rstudio-notebook-image-commit-n=81acd47
1818
odh-rstudio-notebook-image-commit-n-1=5ad18c6
1919
odh-rstudio-gpu-notebook-image-commit-n=81acd47
2020
odh-rstudio-gpu-notebook-image-commit-n-1=5ad18c6
21+
odh-rocm-minimal-notebook-image-commit-n=89da2fc
22+
odh-rocm-pytorch-notebook-image-commit-n=89da2fc
23+
odh-rocm-tensorflow-notebook-image-commit-n=89da2fc

‎manifests/base/commit.yaml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,15 @@ varReference:
8080
kind: ImageStream
8181
apiGroup: image.openshift.io/v1
8282
name: odh-rstudio-gpu-notebook-image-commit-n-1
83+
- path: spec/tags[]/annotations/opendatahub.io\/notebook-build-commit
84+
kind: ImageStream
85+
apiGroup: image.openshift.io/v1
86+
name: odh-rocm-minimal-notebook-image-commit-n
87+
- path: spec/tags[]/annotations/opendatahub.io\/notebook-build-commit
88+
kind: ImageStream
89+
apiGroup: image.openshift.io/v1
90+
name: odh-rocm-pytorch-notebook-image-commit-n
91+
- path: spec/tags[]/annotations/opendatahub.io\/notebook-build-commit
92+
kind: ImageStream
93+
apiGroup: image.openshift.io/v1
94+
name: odh-rocm-tensorflow-notebook-image-commit-n

‎manifests/base/jupyter-rocm-minimal-notebook-imagestream.yaml‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
apiVersion: image.openshift.io/v1
3+
kind: ImageStream
4+
metadata:
5+
labels:
6+
opendatahub.io/notebook-image: "true"
7+
annotations:
8+
opendatahub.io/notebook-image-url: "https://github.com/opendatahub-io/notebooks/blob/main/jupyter/rocm"
9+
opendatahub.io/notebook-image-name: "ROCM"
10+
opendatahub.io/notebook-image-desc: "Jupyter ROCM notebook image for ODH notebooks."
11+
opendatahub.io/notebook-image-order: "9"
12+
name: jupyter-rocm-minimal
13+
spec:
14+
lookupPolicy:
15+
local: true
16+
tags:
17+
# N Version of the image
18+
- annotations:
19+
opendatahub.io/notebook-software: '[{"name":"ROCM","version":"6.1"},{"name":"Python","version":"v3.9"}]'
20+
opendatahub.io/notebook-python-dependencies: '[{"name":"JupyterLab","version":"3.6"},{"name": "Notebook","version": "6.5"}]'
21+
openshift.io/imported-from: quay.io/opendatahub/workbench-images
22+
opendatahub.io/workbench-image-recommended: 'true'
23+
opendatahub.io/notebook-build-commit: $(jupyter-rocm-minimal-notebook-image-commit-n)
24+
from:
25+
kind: DockerImage
26+
name: $(jupyter-rocm-minimal-notebook-image-n)
27+
name: "2024.1"
28+
referencePolicy:
29+
type: Source

‎manifests/base/jupyter-rocm-pytorch-notebook-imagestream.yaml‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
apiVersion: image.openshift.io/v1
3+
kind: ImageStream
4+
metadata:
5+
labels:
6+
opendatahub.io/notebook-image: "true"
7+
annotations:
8+
opendatahub.io/notebook-image-url: "https://github.com/opendatahub-io/notebooks/blob/main/jupyter/rocm/pytorch"
9+
opendatahub.io/notebook-image-name: "ROCM-PyTorch"
10+
opendatahub.io/notebook-image-desc: "Jupyter ROCM optimized PyTorch notebook image for ODH notebooks."
11+
opendatahub.io/notebook-image-order: "14"
12+
name: jupyter-rocm-pytorch
13+
spec:
14+
lookupPolicy:
15+
local: true
16+
tags:
17+
# N Version of the image
18+
- annotations:
19+
opendatahub.io/notebook-software: '[{"name":"Python","version":"v3.9"},{"name":"ROCM-PyTorch","version":"2.3"}]'
20+
opendatahub.io/notebook-python-dependencies: '[{"name":"ROCM-PyTorch","version":"2.3"},{"name":"Tensorboard","version":"2.16"},{"name":"Kafka-Python","version":"2.0"},{"name":"Matplotlib","version":"3.8"},{"name":"Numpy","version":"1.26"},{"name":"Pandas","version":"2.2"},{"name":"Scikit-learn","version":"1.4"},{"name":"Scipy","version":"1.12"},{"name":"Elyra","version":"3.16"},{"name":"PyMongo","version":"4.6"},{"name":"Pyodbc","version":"5.1"}, {"name":"Codeflare-SDK","version":"0.15"}, {"name":"Sklearn-onnx","version":"1.16"}, {"name":"Psycopg","version":"3.1"}, {"name":"MySQL Connector/Python","version":"8.3"}]'
21+
openshift.io/imported-from: quay.io/opendatahub/workbench-images
22+
opendatahub.io/workbench-image-recommended: 'true'
23+
opendatahub.io/notebook-build-commit: $(odh-rocm-pytorch-notebook-image-commit-n)
24+
from:
25+
kind: DockerImage
26+
name: $(odh-rocm-pytorch-notebook-image-commit-n)
27+
name: "2024.1"
28+
referencePolicy:
29+
type: Source

‎manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
apiVersion: image.openshift.io/v1
3+
kind: ImageStream
4+
metadata:
5+
labels:
6+
opendatahub.io/notebook-image: "true"
7+
annotations:
8+
opendatahub.io/notebook-image-url: "https://github.com/opendatahub-io/notebooks/blob/main/jupyter/rocm/tensorflow"
9+
opendatahub.io/notebook-image-name: "ROCM-TensorFlow"
10+
opendatahub.io/notebook-image-desc: "Jupyter ROCM optimized TensorFlow notebook image for ODH notebooks."
11+
opendatahub.io/notebook-image-order: "15"
12+
name: jupyter-rocm-tensorflow
13+
spec:
14+
lookupPolicy:
15+
local: true
16+
tags:
17+
# N Version of the image
18+
- annotations:
19+
opendatahub.io/notebook-software: '[{"name":"Python","version":"v3.9"},{"name":"ROCM-TensorFlow","version":"2.15"}]'
20+
opendatahub.io/notebook-python-dependencies: '[{"name":"ROCM-TensorFlow","version":"2.15"},{"name":"Tensorboard","version":"2.15"},{"name":"Kafka-Python","version":"2.0"},{"name":"Matplotlib","version":"3.8"},{"name":"Numpy","version":"1.26"},{"name":"Pandas","version":"2.2"},{"name":"Scikit-learn","version":"1.4"},{"name":"Scipy","version":"1.12"},{"name":"Elyra","version":"3.16"},{"name":"PyMongo","version":"4.6"},{"name":"Pyodbc","version":"5.1"}, {"name":"Codeflare-SDK","version":"0.15"}, {"name":"Sklearn-onnx","version":"1.16"}, {"name":"Psycopg","version":"3.1"}, {"name":"MySQL Connector/Python","version":"8.3"}]'
21+
openshift.io/imported-from: quay.io/opendatahub/workbench-images
22+
opendatahub.io/workbench-image-recommended: 'true'
23+
opendatahub.io/notebook-build-commit: $(odh-rocm-tensorflow-notebook-image-commit-n)
24+
from:
25+
kind: DockerImage
26+
name: $(odh-rocm-tensorflow-notebook-image-commit-n)
27+
name: "2024.1"
28+
referencePolicy:
29+
type: Source

‎manifests/base/params.env‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,6 @@ odh-rstudio-notebook-image-n=quay.io/opendatahub/workbench-images@sha256:0221e88
1818
odh-rstudio-notebook-image-n-1=quay.io/opendatahub/workbench-images@sha256:06c39f6bfe37df62d5964da786c23c8cef0218c9c1835c2299e6d8575cfab630
1919
odh-rstudio-gpu-notebook-image-n=quay.io/opendatahub/workbench-images@sha256:0851ca8b5d00414d73c6a0f8628b777f4dbfeed4f6d394b03771e6bd70988b30
2020
odh-rstudio-gpu-notebook-image-n-1=quay.io/opendatahub/workbench-images@sha256:1466ee1ad83c3a99b64d6635f8e57fc92658723650399c2a743195fca41cfb65
21+
odh-rocm-minimal-notebook-image-n=quay.io/opendatahub/workbench-images@sha256:cd5237a06edf83773e16e76550619d095f9199f9a212443ca46bf829304375d2
22+
odh-rocm-pytorch-notebook-image-n=quay.io/opendatahub/workbench-images@sha256:a259f8072f21a97c5cec0ef1b9e50bd37aebea1686550bdc0cebdc21c2d4c8c7
23+
odh-rocm-tensorflow-notebook-image-n=quay.io/opendatahub/workbench-images@sha256:39ccee3c69aa1f49e8ca6ae7b7f437e0106646c046034a00e05257671d40fe2c

‎manifests/base/params.yaml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,15 @@ varReference:
8080
kind: ImageStream
8181
apiGroup: image.openshift.io/v1
8282
name: odh-rstudio-gpu-notebook-image-n-1
83+
- path: spec/tags[]/from/name
84+
kind: ImageStream
85+
apiGroup: image.openshift.io/v1
86+
name: odh-rocm-minimal-notebook-image-n
87+
- path: spec/tags[]/from/name
88+
kind: ImageStream
89+
apiGroup: image.openshift.io/v1
90+
name: odh-rocm-pytorch-notebook-image-n
91+
- path: spec/tags[]/from/name
92+
kind: ImageStream
93+
apiGroup: image.openshift.io/v1
94+
name: odh-rocm-tensorflow-notebook-image-n

0 commit comments

Comments
 (0)