Skip to content

Commit b84b6b5

Browse files
committed
feat(deps): add kubeflow-training to workbench images
This commit adds `kubeflow-training[huggingface]` to the following workbench images: - `./jupyter/datascience/ubi9-python-3.11` - `./jupyter/pytorch/ubi9-python-3.11` - `./jupyter/rocm/pytorch/ubi9-python-3.11` - `./jupyter/trustyai/ubi9-python-3.11` - `./codeserver/ubi9-python-3.11` This outcome comes with a slew of caveats and disclaimers: - Due to a dependency conflict, `codeflare-sdk==0.24.3` was **also** pulled into the following workbench images. - `./jupyter/datascience/ubi9-python-3.11` - `./jupyter/pytorch/ubi9-python-3.11` - `./jupyter/rocm/pytorch/ubi9-python-3.11` - `./jupyter/trustyai/ubi9-python-3.11` - ⚠️ In what may be a "controversial" decision, `codeflare-sdk` was **NOT** updated on other workbench images. Since `0.24.3` was a "one-off" release to unblock the `kubeflow-training` inclusion - the thought process here is that normal "sync" procedures on the next official release will standardize the `codeflare-sdk` dependency across all workbench images. This allows us to restrict the testing effort of this commit. - However, as of 2bd35f7, `codeflare-sdk` `0.24.3` was being pulled into our `Pipfile.lock` file - which is why you won't see `Pipfile.lock` addition of `codeflare-sdk` on **this PR** - `jupyter/minmal/ubi9-python-3.11` was deliberately excluded from receiving `kubeflow-training` per discussions with team. - Due to dependency conflicts discovered `tensorflow`-based workbench images,`kubeflow-training` has not been added to those workbench images at this time. This decision was agreed to by affect stakeholders. Core blocking issue can be seen here: - See #2328 in https://github.com/onnx/tensorflow-onnx/issues - Due to a dependency conflict, `transformers = "==4.38.0"` was **also** added to the`./jupyter/trustyai/ubi9-python-3.11` workbench image after discussion with the developer that last worked on the `trustyai` image. While it certainly must be tested, there was no strict requirement that necessitated pinning the `transformers` dependency to `4.36.2` - and the `huggingface` `extras` now introduces a `4.38.0` constraint for `transformers`. Related-to: https://issues.redhat.com/browse/RHOAIENG-12822
1 parent 1a2669c commit b84b6b5

File tree

10 files changed

+1709
-30
lines changed

10 files changed

+1709
-30
lines changed

codeserver/ubi9-python-3.11/Pipfile

100644100755
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@ scikit-learn = "~=1.4.0"
2626
scipy = "~=1.12.0"
2727
skl2onnx = "~=1.16.0"
2828
ipykernel = "~=6.29.3"
29+
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}
2930

30-
# Some extra usefull packages
31+
# Some extra useful packages
3132
opencensus = "~=0.11.4"
3233
smart-open = "~=7.0.1"
3334
virtualenv = "~=20.25.1"

codeserver/ubi9-python-3.11/Pipfile.lock

Lines changed: 638 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jupyter/datascience/ubi9-python-3.11/Pipfile

100644100755
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ scikit-learn = "~=1.5.1"
1818
scipy = "~=1.14.1"
1919
skl2onnx = "~=1.17.0"
2020
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
21-
codeflare-sdk = "~=0.24.0"
21+
codeflare-sdk = "~=0.24.3"
22+
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}
2223

2324
# DB connectors
2425
pymongo = "~=4.8.0"

jupyter/datascience/ubi9-python-3.11/Pipfile.lock

Lines changed: 441 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jupyter/pytorch/ubi9-python-3.11/Pipfile

100644100755
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ scikit-learn = "~=1.5.1"
2828
scipy = "~=1.14.1"
2929
skl2onnx = "~=1.17.0"
3030
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
31-
codeflare-sdk = "~=0.24.0"
31+
codeflare-sdk = "~=0.24.3"
32+
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}
3233

3334
# DB connectors
3435
pymongo = "~=4.8.0"

jupyter/pytorch/ubi9-python-3.11/Pipfile.lock

Lines changed: 287 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jupyter/rocm/pytorch/ubi9-python-3.11/Pipfile

100644100755
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ scikit-learn = "~=1.5.1"
3030
scipy = "~=1.14.1"
3131
skl2onnx = "~=1.17.0"
3232
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
33-
codeflare-sdk = "~=0.24.0"
33+
codeflare-sdk = "~=0.24.3"
34+
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}
3435

3536
# DB connectors
3637
pymongo = "~=4.8.0"

jupyter/rocm/pytorch/ubi9-python-3.11/Pipfile.lock

Lines changed: 287 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jupyter/trustyai/ubi9-python-3.11/Pipfile

100644100755
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ name = "pytorch"
1414
# PyTorch packages
1515
torch = {version = "~=2.2.1", index = "pytorch"}
1616
# TrustyAI packages
17-
transformers = "~=4.36.2"
17+
transformers = "~=4.38.0"
1818
datasets = "~=2.21.0"
1919
accelerate = "~=0.34.2"
2020
trustyai = "~=0.6.1"
@@ -30,7 +30,8 @@ scikit-learn = "~=1.2.1" # Should be pinned down to this version in order to be
3030
scipy = "~=1.14.1"
3131
skl2onnx = "~=1.17.0"
3232
onnxconverter-common = "~=1.13.0" # Required for skl2onnx, as upgraded version is not compatible with protobuf
33-
codeflare-sdk = "~=0.24.0"
33+
codeflare-sdk = "~=0.24.3"
34+
kubeflow-training = {extras = ["huggingface"], version = "==1.8.1"}
3435

3536
# DB connectors
3637
pymongo = "~=4.8.0"

jupyter/trustyai/ubi9-python-3.11/Pipfile.lock

Lines changed: 45 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)