Skip to content

Commit c8b73af

Browse files
authored
NO-JIRA: tests(gha/k8s): remove setting the node-role.kubernetes.io/control-plane taint (#1068)
For some reason, the `kubeadm.yaml` was setting the taint, only for `build-notebooks-TEMPLATE.yaml` to immediately unset it. This became obvious after migrating to v1beta4 `kubeadm.yaml`.
1 parent 652d69d commit c8b73af

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

.github/workflows/build-notebooks-TEMPLATE.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -471,10 +471,6 @@ jobs:
471471
# Once you have found the failing container, you can inspect its logs with:
472472
# crictl --runtime-endpoint unix:///var/run/crio/crio.sock logs CONTAINERID
473473
474-
- name: Untaint the master
475-
if: ${{ steps.have-tests.outputs.tests == 'true' }}
476-
run: kubectl taint nodes --all node-role.kubernetes.io/control-plane-
477-
478474
- name: Show nodes status and wait for readiness
479475
if: ${{ steps.have-tests.outputs.tests == 'true' }}
480476
run: |

ci/cached-builds/kubeadm.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ nodeRegistration:
2121
criSocket: unix:///var/run/crio/crio.sock
2222
imagePullPolicy: IfNotPresent
2323
imagePullSerial: true
24-
taints:
25-
- effect: NoSchedule
26-
key: node-role.kubernetes.io/control-plane
24+
taints: []
2725
kubeletExtraArgs:
2826
# Need to have enough disk space for Kubelet, so move root-dir on the LVM volume
2927
# Note: the internets discourage from changing the default because storage plugins may then struggle

0 commit comments

Comments
 (0)