Skip to content

Commit dc9b96a

Browse files
committed
Update build-notebooks-TEMPLATE with platform BUILD_ARG change
1 parent 03430e9 commit dc9b96a

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/build-notebooks-TEMPLATE.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ jobs:
4343
TRIVY_VULNDB: "/home/runner/.local/share/containers/trivy_db"
4444
# Targets (and their folder) that should be scanned using FS instead of IMAGE scan due to resource constraints
4545
TRIVY_SCAN_FS_JSON: '{}'
46+
BUILD_ARCH: ${{ inputs.platform }}
4647

4748
steps:
4849

@@ -326,8 +327,7 @@ jobs:
326327
fromJson(inputs.github).event_name == 'workflow_dispatch' }}
327328
env:
328329
IMAGE_TAG: "${{ steps.calculated_vars.outputs.IMAGE_TAG }}"
329-
# Configuring `podman build --platform=` through CONTAINER_BUILD_CACHE_ARGS is a venerable hack on this project
330-
CONTAINER_BUILD_CACHE_ARGS: "${{ steps.extra-podman-build-args.outputs.EXTRA_PODMAN_BUILD_ARGS }} --platform=${{ inputs.platform }} --cache-from ${{ env.CACHE }} --cache-to ${{ env.CACHE }}"
330+
CONTAINER_BUILD_CACHE_ARGS: "${{ steps.extra-podman-build-args.outputs.EXTRA_PODMAN_BUILD_ARGS }} --cache-from ${{ env.CACHE }} --cache-to ${{ env.CACHE }}"
331331
- name: "pull_request: make ${{ inputs.target }}"
332332
run: |
333333
# print running stats on disk occupancy
@@ -338,8 +338,7 @@ jobs:
338338
fromJson(inputs.github).event_name == 'pull_request_target' }}"
339339
env:
340340
IMAGE_TAG: "${{ steps.calculated_vars.outputs.IMAGE_TAG }}"
341-
# Configuring `podman build --platform=` through CONTAINER_BUILD_CACHE_ARGS is a venerable hack on this project
342-
CONTAINER_BUILD_CACHE_ARGS: "${{ steps.extra-podman-build-args.outputs.EXTRA_PODMAN_BUILD_ARGS }} --platform=${{ inputs.platform }} --cache-from ${{ env.CACHE }}"
341+
CONTAINER_BUILD_CACHE_ARGS: "${{ steps.extra-podman-build-args.outputs.EXTRA_PODMAN_BUILD_ARGS }} --cache-from ${{ env.CACHE }}"
343342
# We don't have access to image registry, so disable pushing
344343
PUSH_IMAGES: "no"
345344

0 commit comments

Comments
 (0)