Remove requirments-elyra.txt from the code base (#761)

* Remove requirments-elyra.txt from the code base

* changes that were requested in review

* also remove volumeMounts from pod.yaml files

* fix linter errors

./runtimes/rocm-tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml
  Error: 11:1 [empty-lines] too many blank lines (1 > 0)

./runtimes/tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml
  Error: 11:1 [empty-lines] too many blank lines (1 > 0)

and wrongly intended line in Makefile, that's not linted automatically

* fix missing comment starter # marks in `utils/requirements-elyra.txt`

without it, pip would error out on this invalid requirements file

---------

Co-authored-by: Jiri Daněk <[email protected]>

Author: dibryant

Makefile

@@ -538,6 +538,7 @@ validate-runtime-image: bin/kubectl
 	$(info # Running tests for $(NOTEBOOK_NAME) runtime...)
 	$(KUBECTL_BIN) wait --for=condition=ready pod runtime-pod --timeout=300s
 	@required_commands=$(REQUIRED_RUNTIME_IMAGE_COMMANDS) ; \
+	fail=0 ; \
 	if [[ $$image == "" ]] ; then \
 		echo "Usage: make validate-runtime-image image=<container-image-name>" ; \
 		exit 1 ; \
@@ -552,11 +553,12 @@ validate-runtime-image: bin/kubectl
 		fi; \
 		if [ $$cmd == "python3" ]; then \
 			echo "=> Checking notebook execution..." ; \
-			$(KUBECTL_BIN) exec runtime-pod -- /bin/sh -c "python3 -m pip install -r /opt/app-root/elyra/requirements-elyra.txt && \
+			$(KUBECTL_BIN) exec runtime-pod -- /bin/sh -c "curl https://raw.githubusercontent.com/opendatahub-io/elyra/refs/heads/main/etc/generic/requirements-elyra.txt --output req.txt && \ 
+				python3 -m pip install -r req.txt > /dev/null && \
 				curl https://raw.githubusercontent.com/nteract/papermill/main/papermill/tests/notebooks/simple_execute.ipynb --output simple_execute.ipynb && \
 				python3 -m papermill simple_execute.ipynb output.ipynb > /dev/null" ; \
 			if [ $$? -ne 0 ]; then \
-				echo "ERROR: Image does not meet Python requirements criteria in requirements-elyra.txt" ; \
+				echo "ERROR: Image does not meet Python requirements criteria in pipfile" ; \
 				fail=1; \
 			fi; \
 		fi; \

runtimes/datascience/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -8,7 +8,3 @@ images:
   - name: runtime-workbench
     newName: quay.io/opendatahub/workbench-images
     newTag: runtime-datascience-ubi9-python-3.11
-configMapGenerator:
-  - name: req-config
-    files:
-      - requirements-elyra.txt

runtimes/datascience/ubi9-python-3.11/kustomize/base/pod.yaml

@@ -20,10 +20,3 @@ spec:
         requests:
           cpu: 500m
           memory: 500Mi
-      volumeMounts:
-        - name: config
-          mountPath: /opt/app-root/elyra
-  volumes:
-    - name: config
-      configMap:
-        name: req-config

runtimes/datascience/ubi9-python-3.11/kustomize/base/requirements-elyra.txt

@@ -1,71 +1,7 @@
-# Copied from: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt
-
+# Originally copied from: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt
 # This is a comprehensive list of python dependencies that Elyra requires to execute Jupyter notebooks.
-ipykernel==6.29.5
-ipython==8.27.0
-ipython-genutils==0.2.0
-jinja2==3.1.4
-jupyter-client==8.6.3
-jupyter-core==5.7.2
-MarkupSafe==2.1.5
-minio==7.2.8
-nbclient==0.10.0
-nbconvert==7.16.4
-nbformat==5.10.4
-papermill==2.6.0
-pyzmq==26.2.0
-prompt-toolkit==3.0.47
-requests==2.32.3
-tornado==6.4.1
-traitlets==5.14.3
-urllib3==2.2.3
-#
-# These excluded are transitive dependencies of the included python packages.
-#ansiwrap==0.8.4
-#appnope==0.1.3
-#asttokens==2.0.5
-#attrs==21.4.0
-#backcall==0.2.0
-#beautifulsoup4==4.11.1
-#bleach==5.0.0
-#certifi==2021.10.8
-#charset-normalizer==2.0.12
-#click==8.1.3
-#debugpy==1.6.0
-#decorator==5.1.1
-#defusedxml==0.7.1
-#entrypoints==0.4
-#executing==0.8.3
-#fastjsonschema==2.15.3
-#idna==3.3
-#importlib-resources==5.7.1
-#jedi==0.18.1
-#jsonschema==4.5.1
-#jupyterlab-pygments==0.2.2
-#matplotlib-inline==0.1.3
-#mistune==0.8.4
-#nest-asyncio==1.5.5
-#packaging==21.3
-#pandocfilters==1.5.0
-#parso==0.8.3
-#pexpect==4.8.0
-#pickleshare==0.7.5
-#psutil==5.9.0
-#ptyprocess==0.7.0
-#pure-eval==0.2.2
-#Pygments==2.12.0
-#pyparsing==3.0.9
-#pyrsistent==0.18.1
-#python-dateutil==2.8.2
-#PyYAML==6.0
-#six==1.16.0
-#soupsieve==2.3.2.post1
-#stack-data==0.2.0
-#tenacity==8.0.1
-#textwrap3==0.9.2
-#tinycss2==1.1.1
-#tqdm==4.64.0
-#wcwidth==0.2.5
-#webencodings==0.5.1
-#zipp==3.8.0
-#
+
+# This (now effectively blank) requirements.txt file is left here for the exclusive reason to escape falling into
+# https://github.com/opendatahub-io/elyra/blob/0ec8a571df6b3614aca91f20fe0b1dbdc8743dc6/elyra/pipeline/kfp/processor_kfp.py#L1099,
+# in case the details are need please follow the comprehensive list of python dependencies present here:
+# https://raw.githubusercontent.com/opendatahub-io/elyra/refs/heads/main/etc/generic/requirements-elyra.txt

runtimes/datascience/ubi9-python-3.11/utils/requirements-elyra.txt

@@ -8,7 +8,3 @@ images:
   - name: runtime-workbench
     newName: quay.io/opendatahub/workbench-images
     newTag: runtime-minimal-ubi9-python-3.11
-configMapGenerator:
-  - name: req-config
-    files:
-      - requirements-elyra.txt

runtimes/minimal/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -20,10 +20,3 @@ spec:
         requests:
           cpu: 500m
           memory: 500Mi
-      volumeMounts:
-        - name: config
-          mountPath: /opt/app-root/elyra
-  volumes:
-    - name: config
-      configMap:
-        name: req-config

runtimes/minimal/ubi9-python-3.11/kustomize/base/pod.yaml

@@ -1,71 +1,7 @@
-# Copied from: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt
-
+# Originally copied from: https://github.com/elyra-ai/elyra/blob/main/etc/generic/requirements-elyra.txt
 # This is a comprehensive list of python dependencies that Elyra requires to execute Jupyter notebooks.
-ipykernel==6.29.5
-ipython==8.27.0
-ipython-genutils==0.2.0
-jinja2==3.1.4
-jupyter-client==8.6.3
-jupyter-core==5.7.2
-MarkupSafe==2.1.5
-minio==7.2.8
-nbclient==0.10.0
-nbconvert==7.16.4
-nbformat==5.10.4
-papermill==2.6.0
-pyzmq==26.2.0
-prompt-toolkit==3.0.47
-requests==2.32.3
-tornado==6.4.1
-traitlets==5.14.3
-urllib3==2.2.3
-#
-# These excluded are transitive dependencies of the included python packages.
-#ansiwrap==0.8.4
-#appnope==0.1.3
-#asttokens==2.0.5
-#attrs==21.4.0
-#backcall==0.2.0
-#beautifulsoup4==4.11.1
-#bleach==5.0.0
-#certifi==2021.10.8
-#charset-normalizer==2.0.12
-#click==8.1.3
-#debugpy==1.6.0
-#decorator==5.1.1
-#defusedxml==0.7.1
-#entrypoints==0.4
-#executing==0.8.3
-#fastjsonschema==2.15.3
-#idna==3.3
-#importlib-resources==5.7.1
-#jedi==0.18.1
-#jsonschema==4.5.1
-#jupyterlab-pygments==0.2.2
-#matplotlib-inline==0.1.3
-#mistune==0.8.4
-#nest-asyncio==1.5.5
-#packaging==21.3
-#pandocfilters==1.5.0
-#parso==0.8.3
-#pexpect==4.8.0
-#pickleshare==0.7.5
-#psutil==5.9.0
-#ptyprocess==0.7.0
-#pure-eval==0.2.2
-#Pygments==2.12.0
-#pyparsing==3.0.9
-#pyrsistent==0.18.1
-#python-dateutil==2.8.2
-#PyYAML==6.0
-#six==1.16.0
-#soupsieve==2.3.2.post1
-#stack-data==0.2.0
-#tenacity==8.0.1
-#textwrap3==0.9.2
-#tinycss2==1.1.1
-#tqdm==4.64.0
-#wcwidth==0.2.5
-#webencodings==0.5.1
-#zipp==3.8.0
-#
+
+# This (now effectively blank) requirements.txt file is left here for the exclusive reason to escape falling into
+# https://github.com/opendatahub-io/elyra/blob/0ec8a571df6b3614aca91f20fe0b1dbdc8743dc6/elyra/pipeline/kfp/processor_kfp.py#L1099,
+# in case the details are need please follow the comprehensive list of python dependencies present here:
+# https://raw.githubusercontent.com/opendatahub-io/elyra/refs/heads/main/etc/generic/requirements-elyra.txt

runtimes/minimal/ubi9-python-3.11/kustomize/base/requirements-elyra.txt

@@ -8,7 +8,3 @@ images:
   - name: runtime-workbench
     newName: quay.io/opendatahub/workbench-images
     newTag: runtime-pytorch-ubi9-python-3.11
-configMapGenerator:
-  - name: req-config
-    files:
-      - requirements-elyra.txt