Skip to content

Systematic fix: ROCm TensorFlow kustomization files incorrectly reference PyTorch image tags #1267

@coderabbitai

Description

@coderabbitai

Problem Description

ROCm TensorFlow kustomization files are incorrectly referencing PyTorch image tags instead of TensorFlow image tags, causing deployed pods to use the wrong runtime environment. This is a systematic copy-paste error affecting multiple Python versions.

Affected Files

Python 3.11 (main branch):
jupyter/rocm/tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml

  • Current: newTag: jupyter-pytorch-ubi9-python-3.11-2023a-20231002-4e9bbb3
  • Expected: newTag: rocm-jupyter-tensorflow-ubi9-python-3.11

Python 3.12 (PR #1259):
jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/kustomization.yaml

  • Current: newTag: jupyter-pytorch-ubi9-python-3.12-2023a-20231002-4e9bbb3
  • Expected: newTag: rocm-jupyter-tensorflow-ubi9-python-3.12

Impact

  • StatefulSets deploy with PyTorch images instead of TensorFlow images
  • TensorFlow-specific tests fail due to incorrect runtime environment
  • Users get PyTorch environment when expecting TensorFlow capabilities

Root Cause

Copy-paste error from ROCm PyTorch kustomization files when creating ROCm TensorFlow variants.

Acceptance Criteria

  • Fix image tag in jupyter/rocm/tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml
  • Fix image tag in jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/kustomization.yaml
  • Verify correct image tags follow the pattern: rocm-jupyter-tensorflow-ubi9-python-X.Y
  • Ensure existing CI/CD pipeline tests pass with corrected tags
  • Document the correct naming pattern to prevent future copy-paste errors

Implementation Notes

Reference the working ROCm PyTorch pattern:

  • jupyter/rocm/pytorch/ubi9-python-3.11/kustomize/base/kustomization.yaml uses rocm-jupyter-pytorch-ubi9-python-3.11
  • jupyter/rocm/pytorch/ubi9-python-3.12/kustomize/base/kustomization.yaml uses rocm-jupyter-pytorch-ubi9-python-3.12

Backlinks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions