Skip running builds when dealing with Konflux nudge PRs

[jiridanek]

Jobs such as the one linked below should not run, that is waste of time and resources

• https://github.com/opendatahub-io/notebooks/actions/runs/16810526511

[jiridanek]

@coderabbitai look for duplicates and other similar issues we now have with github actions that need to be resolved

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

I'll help you identify duplicate and similar GitHub Actions issues that need resolution. Let me search through the repository's existing issues and workflows to get a comprehensive view.

---

🏁 Script executed:

#!/bin/bash
# Search for existing GitHub issues related to GitHub Actions, workflows, and CI
echo "=== Searching for GitHub Actions related issues ==="
gh issue list --repo opendatahub-io/notebooks --state all --search "github actions OR workflow OR ci OR artifact OR insta-merge OR konflux" --limit 50

echo -e "\n=== Searching for recent issues with specific keywords ==="
gh issue list --repo opendatahub-io/notebooks --state open --search "duplicate OR similar OR actions OR workflow" --limit 20

echo -e "\n=== Looking at current GitHub Actions workflows ==="
find .github/workflows -name "*.yml" -o -name "*.yaml" | head -10

echo -e "\n=== Checking for any workflow-related problems in recent issues ==="
gh issue list --repo opendatahub-io/notebooks --state open --limit 30 | grep -i -E "(action|workflow|ci|build|artifact)"

Length of output: 10197

---

Let me examine the GitHub Actions workflow files more closely to identify patterns and potential duplicates:

---

🏁 Script executed:

#!/bin/bash
# Examine the workflow files to understand structure and identify issues
echo "=== Examining key workflow files ==="
echo "--- insta-merge.yaml (related to issue #1749) ---"
if [ -f .github/workflows/insta-merge.yaml ]; then
    head -20 .github/workflows/insta-merge.yaml
else 
    echo "insta-merge.yaml not found"
fi

echo -e "\n--- build template and PR workflows ---"
ls -la .github/workflows/build-notebooks*.yaml

echo -e "\n--- Checking for Konflux-related triggers in workflows ---"
grep -r -n -A3 -B3 -i "konflux\|nudge" .github/workflows/ || echo "No explicit Konflux references found"

echo -e "\n--- Looking for duplicate workflow patterns ---"
echo "Build workflow files:"
wc -l .github/workflows/build-notebooks*.yaml

echo -e "\n--- Examining specific issues mentioned ---"
echo "Issue #1749 vs #1510 - both about Konflux nudge PRs:"
gh issue view 1749 --repo opendatahub-io/notebooks | head -10
echo "---"
gh issue view 1510 --repo opendatahub-io/notebooks | head -10

Length of output: 4540

---

🏁 Script executed:

#!/bin/bash
# Look for more specific duplicates and related issues
echo "=== Analyzing potential duplicate issues ==="

echo "--- Workflow duplication issues ---"
gh issue view 1504 --repo opendatahub-io/notebooks | head -15
echo "---"
gh issue view 1185 --repo opendatahub-io/notebooks | head -15

echo -e "\n--- GitHub Actions infrastructure issues ---"
gh issue view 1434 --repo opendatahub-io/notebooks | head -15
echo "---"
gh issue view 1196 --repo opendatahub-io/notebooks | head -15

echo -e "\n--- Checking for YAML/syntax related issues ---"
gh issue view 1370 --repo opendatahub-io/notebooks --comments | head -20

Length of output: 2574

---

Let me get more details about the potential duplicates and examine the current insta-merge workflow:

---

🏁 Script executed:

#!/bin/bash
# Get full details of the duplicate issues and examine insta-merge workflow
echo "=== Examining the full insta-merge.yaml workflow ==="
cat .github/workflows/insta-merge.yaml

echo -e "\n=== Getting full details of duplicate Konflux issues ==="
echo "--- Issue #1749 (current) ---"
gh issue view 1749 --repo opendatahub-io/notebooks --comments

echo -e "\n--- Issue #1510 (older duplicate) ---"
gh issue view 1510 --repo opendatahub-io/notebooks --comments

echo -e "\n=== Checking if these issues have different scopes or solutions ==="
echo "Searching for any other related Konflux trigger issues:"
gh issue list --repo opendatahub-io/notebooks --search "Konflux trigger OR nudge merge OR insta-merge" --state all --limit 10

Length of output: 2950

---

@jiridanek I've conducted a comprehensive analysis of duplicate and similar GitHub Actions issues in the repository. Here are the findings that need resolution:

🔄 Clear Duplicates That Should Be Consolidated

1. Konflux Nudge PR Issues (EXACT DUPLICATES)

• Issue Skip running builds when dealing with Konflux nudge PRs #1749: "Skip running builds when dealing with Konflux nudge PRs" (Aug 7, 2025)
• Issue Don't trigger after Konflux nudge merges #1510: "Don't trigger after Konflux nudge merges" (Jul 25, 2025)

Analysis: Both issues address the identical problem - preventing wasteful builds when Konflux bot creates nudge PRs. Issue #1749 is newer and has your current attention, while #1510 is the older duplicate with no comments.

Recommendation: Close #1510 as duplicate of #1749, consolidating discussion in the newer issue.

🔧 Related Issues That Could Be Addressed Together

2. GitHub Actions Infrastructure/LVM Issues

• Issue [2024b+?] 🚨 Infrastructure: GitHub Actions LVM setup failure due to ext4 signature detection #1434: "GitHub Actions LVM setup failure due to ext4 signature detection"
• Issue GitHub Actions failure: fallocate invalid length in gha_lvm_overlay.sh #1196: "GitHub Actions failure: fallocate invalid length in gha_lvm_overlay.sh"

Analysis: Both stem from LVM volume setup problems in GitHub Actions. While potentially different root causes, they're part of the same infrastructure stability concern.

Recommendation: Consider creating a master issue for "GitHub Actions LVM Infrastructure Stability" and reference both issues.

3. Workflow Code Duplication Issues

• Issue Drop duplicated documentation links in GitHub Actions workflow template #1504: "Drop duplicated documentation links in GitHub Actions workflow template"
• Issue Refactor notebooks-release workflow to eliminate code duplication using reusable workflows #1185: "Refactor notebooks-release workflow to eliminate code duplication using reusable workflows"

Analysis: Both address code duplication in workflows but at different scopes - #1504 is specific documentation links, #1185 is broader workflow refactoring.

Recommendation: These can be addressed as part of a systematic workflow cleanup initiative.

4. Konflux Build Optimization Cluster

• Issue Timeout issues on clamav scan in Konflux pr builds #1695: "Timeout issues on clamav scan in Konflux pr builds"
• Issue run clamav konflux build step in parallel #975: "run clamav konflux build step in parallel"
• Issue flaky konflux pr image push #963: "flaky konflux pr image push"
• Issue konflux issue, got oomkill from clamav-scan in rocm-runtime-pytorch-ubi9-python-3-11-on-pull-request #998: "konflux issue, got oomkill from clamav-scan"

Analysis: Multiple issues related to Konflux build performance and reliability, particularly around clamav scanning.

Recommendation: Consider consolidating under a master "Konflux Build Performance & Reliability" issue.

📋 Resolved Issues (For Reference)

• Issue YAML Linting Issues in GitHub Actions Workflow #1370: "YAML Linting Issues in GitHub Actions Workflow" (CLOSED)
• Issue 🔧 YAML Syntax Error in Tekton PipelineRun: Trailing Backslash Causes Parsing Failure #1371: "YAML Syntax Error in Tekton PipelineRun" (CLOSED)

🎯 Immediate Actions Needed

1. Close Don't trigger after Konflux nudge merges #1510 as duplicate of Skip running builds when dealing with Konflux nudge PRs #1749
2. Consolidate Konflux build performance issues (Timeout issues on clamav scan in Konflux pr builds #1695, run clamav konflux build step in parallel #975, flaky konflux pr image push #963, konflux issue, got oomkill from clamav-scan in rocm-runtime-pytorch-ubi9-python-3-11-on-pull-request #998) under a single tracking issue
3. Consider grouping LVM infrastructure issues ([2024b+?] 🚨 Infrastructure: GitHub Actions LVM setup failure due to ext4 signature detection #1434, GitHub Actions failure: fallocate invalid length in gha_lvm_overlay.sh #1196) for systematic resolution

This aligns with your established pattern of consolidating related issues systematically rather than maintaining separate tracking for the same underlying problems.

---

🧠 Learnings used

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1269
File: codeserver/ubi9-python-3.12/utils/process.sh:17-19
Timestamp: 2025-07-03T14:00:00.909Z
Learning: jiridanek efficiently identifies when CodeRabbit review suggestions are already covered by existing comprehensive issues, demonstrating excellent issue management and avoiding duplicate tracking of the same improvements across multiple locations.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-04T06:39:57.871Z
Learning: jiridanek efficiently manages duplicate issues in opendatahub-io/notebooks by identifying duplicates and requesting consolidation to avoid redundant tracking. When issue #1295 was found to be an identical duplicate of #1293, both covering shell scripting improvements in the codeserver image, he requested consolidation and closure of the duplicate, demonstrating systematic issue management practices.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1269
File: codeserver/ubi9-python-3.12/nginx/root/usr/share/container-scripts/nginx/common.sh:1-3
Timestamp: 2025-07-03T12:07:19.365Z
Learning: jiridanek consistently requests GitHub issue creation for technical improvements identified during code reviews in opendatahub-io/notebooks, ensuring systematic tracking of code quality enhancements like shell script portability issues with comprehensive descriptions, solution options, and acceptance criteria.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-09T09:12:44.088Z
Learning: jiridanek requested GitHub issue creation for GitHub Actions artifact naming conflict during PR #1357 review, specifically for a failing actions/upload-artifactv4 step with 409 Conflict error. Issue was created with comprehensive problem description covering artifact naming conflicts, root cause analysis of duplicate names in concurrent workflows, four solution options (enhanced naming, overwriting, conditional uploads, matrix-aware naming) with code examples, detailed acceptance criteria, implementation guidance, testing approach, and proper context linking, continuing the established pattern of systematic CI/CD and code quality improvements through detailed issue tracking.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/service.yaml:5-15
Timestamp: 2025-07-02T18:32:05.701Z
Learning: jiridanek consolidates related issues systematically in opendatahub-io/notebooks. When multiple issues (#1265, #1264, #1251) stem from the same root cause (kustomize label/selector conflicts), he combines them into a single master issue (#1236) that addresses the problem comprehensively across all affected images rather than maintaining separate issues for each component.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/service.yaml:5-15
Timestamp: 2025-07-02T18:32:05.701Z
Learning: jiridanek consolidates related issues systematically in opendatahub-io/notebooks. When multiple issues (#1265, #1264, #1251) stem from the same root cause (kustomize label/selector conflicts), he combines them into a single master issue (#1236) that addresses the problem comprehensively across all affected images rather than maintaining separate issues for each component.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/service.yaml:5-15
Timestamp: 2025-07-02T18:32:05.701Z
Learning: jiridanek consolidates related issues systematically in opendatahub-io/notebooks. When multiple issues (#1265, #1264, #1251) stem from the same root cause (kustomize label/selector conflicts), he combines them into a single master issue (#1236) that addresses the problem comprehensively across all affected images rather than maintaining separate issues for each component.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1151
File: jupyter/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb:31-34
Timestamp: 2025-07-01T07:03:05.385Z
Learning: jiridanek demonstrates excellent pattern recognition for identifying duplicated code issues across the opendatahub-io/notebooks repository. When spotting a potential problem in test notebooks, he correctly assesses that such patterns are likely replicated across multiple similar files rather than being isolated incidents, leading to more effective systematic solutions.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue #1370 was successfully created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue was created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/test/test_notebook.ipynb:71-76
Timestamp: 2025-07-04T06:04:43.085Z
Learning: jiridanek requested GitHub issue creation for duplicate CSV loading and validation problem in jupyter/trustyai/ubi9-python-3.12/test/test_notebook.ipynb during PR #1306 review. Issue #1322 was created with comprehensive problem description covering code redundancy, runtime failure risks, network inefficiency, and test reliability concerns, along with detailed solution including duplicate line removal, data validation implementation, repository-wide audit, acceptance criteria, implementation guidance, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1230
File: jupyter/minimal/ubi9-python-3.12/Dockerfile.rocm:43-55
Timestamp: 2025-07-01T06:48:21.070Z
Learning: When security concerns are raised during PR reviews in opendatahub-io/notebooks, comprehensive follow-up issues are created (often by CodeRabbit) to track all related security enhancements with clear acceptance criteria and implementation guidance. This ensures security improvements are systematically addressed in dedicated efforts rather than blocking current deliverables.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1333
File: runtimes/rocm-pytorch/ubi9-python-3.12/utils/bootstrapper.py:1-769
Timestamp: 2025-07-08T19:35:49.482Z
Learning: jiridanek requested GitHub issue creation for bootstrapper code duplication problem in runtimes/rocm-pytorch/ubi9-python-3.12/utils/bootstrapper.py during PR #1333 review. After an initial failed attempt, issue #1349 was successfully created with comprehensive problem description covering maintenance overhead and consistency risks from duplicate implementations across 5 Python 3.12 runtime environments, four solution options (symlinks, import-based, template-based, direct shared import) with pros/cons analysis, clear acceptance criteria for consolidation and maintainability, step-by-step implementation guidance, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#968
File: codeserver/ubi9-python-3.11/Dockerfile.cpu:138-140
Timestamp: 2025-08-01T16:07:58.701Z
Learning: jiridanek prefers architectural solutions that eliminate problems entirely rather than just fixing immediate technical issues. When presented with a pipeline safety concern about micropipenv requirements generation, he suggested removing micropipenv from the build process altogether by using pre-committed requirements.txt files, demonstrating preference for simplification and deterministic builds over complex workarounds.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1600
File: Makefile:0-0
Timestamp: 2025-08-02T08:49:03.735Z
Learning: jiridanek decided to eliminate '+' characters entirely from Makefile target names during PR #1600 review instead of implementing complex substitution workarounds, demonstrating his consistent preference for architectural solutions that eliminate problems at the source rather than adding complexity to handle edge cases.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm:56-66
Timestamp: 2025-07-02T18:19:49.397Z
Learning: jiridanek consistently creates comprehensive follow-up GitHub issues for security concerns raised during PR reviews in opendatahub-io/notebooks, ensuring systematic tracking and resolution of supply-chain security improvements like GPG signature verification for package repositories.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-10T18:51:05.012Z
Learning: In opendatahub-io/notebooks, when GitHub Actions build jobs fail and produce no logs, this typically indicates an infrastructure or workflow setup failure (such as runner allocation issues or misconfiguration), not a code-level problem. This pattern is distinct from code/configuration failures, which produce error logs.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-10T18:47:28.810Z
Learning: To analyze GitHub Actions runs for a specific PR in opendatahub-io/notebooks, always use `gh pr checks <PR_NUMBER> --repo opendatahub-io/notebooks` to list all runs, then fetch logs for each failed run using `gh run view <RUN_ID> --log --repo opendatahub-io/notebooks`. This approach is more reliable than branch filtering or other methods.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-09T11:22:11.653Z
Learning: When analyzing OpenShift CI/Prow job failures in opendatahub-io/notebooks, jobs that appear to "complete successfully" may actually have failed at the image build stage and never executed any e2e tests. Proper analysis requires checking if image builds succeeded before concluding that tests passed or the job was successful.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-09T11:22:11.653Z
Learning: When analyzing OpenShift CI/Prow job failures in opendatahub-io/notebooks, jobs that appear to "complete successfully" may actually have failed at the image build stage and never executed any e2e tests. Proper analysis requires checking if image builds succeeded before concluding that tests passed or the job was successful.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-10T06:25:05.151Z
Learning: To analyze GitHub Actions runs for a specific PR in opendatahub-io/notebooks, use `gh pr checks <PR_NUMBER> --repo opendatahub-io/notebooks` to list all checks/runs, then `gh run view <RUN_ID> --log --repo opendatahub-io/notebooks` to get detailed logs from specific runs. This is more effective than using `gh run list` with branch filtering.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-10T06:25:05.151Z
Learning: To analyze GitHub Actions runs for a specific PR in opendatahub-io/notebooks, use `gh pr checks <PR_NUMBER> --repo opendatahub-io/notebooks` to list all checks/runs, then `gh run view <RUN_ID> --log --repo opendatahub-io/notebooks` to get detailed logs from specific runs. This is more effective than using `gh run list` with branch filtering.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-10T06:25:05.151Z
Learning: To analyze GitHub Actions runs for a specific PR in opendatahub-io/notebooks, use `gh pr checks <PR_NUMBER> --repo opendatahub-io/notebooks` to list all checks/runs, then `gh run view <RUN_ID> --log --repo opendatahub-io/notebooks` to get detailed logs from specific runs. This is more effective than using `gh run list` with branch filtering.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-06-16T11:32:09.203Z
Learning: Runtime deployment tests in opendatahub-io/notebooks may show PodSecurity warnings about allowPrivilegeEscalation, capabilities, runAsNonRoot, and seccompProfile settings. These warnings occur on OpenShift but not on GitHub Actions because GitHub Actions uses upstream Kubernetes without SecurityContextConstraints (SCC).

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-10T18:44:19.269Z
Learning: When asked about PR checks in opendatahub-io/notebooks, this includes both OpenShift CI/Prow job results AND GitHub Actions workflow results. Both should be analyzed comprehensively using appropriate commands like `gh pr checks <PR_NUMBER>` for GitHub Actions and direct log analysis for OpenShift CI failures.

---

Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-10T18:44:19.269Z
Learning: When asked about PR checks in opendatahub-io/notebooks, this includes both OpenShift CI/Prow job results AND GitHub Actions workflow results. Both should be analyzed comprehensively using appropriate commands like `gh pr checks <PR_NUMBER>` for GitHub Actions and direct log analysis for OpenShift CI failures.