-
Notifications
You must be signed in to change notification settings - Fork 106
Open
Description
Summary
Micropipenv CLI invocations are still present in a few Dockerfiles. As the repository is converging on a consistent, deterministic requirements-based installation approach without relying on micropipenv at build time, these remaining calls should be removed for consistency and to reduce build complexity.
Why this matters
- Consistency: Aligns these images with the rest of the repo's installation approach.
- Determinism: Avoids additional tooling layers during image build.
- Maintenance: Simplifies future dependency management.
Detected occurrences
A repo-wide search found the following micropipenv CLI usage (file:line):
- jupyter/pytorch+llmcompressor/ubi9-python-3.11/Dockerfile.cuda:218
- runtimes/pytorch+llmcompressor/ubi9-python-3.11/Dockerfile.cuda:146
For reference, the matching lines were:
runtimes/pytorch+llmcompressor/ubi9-python-3.11/Dockerfile.cuda:146: micropipenv install --dev && \
jupyter/pytorch+llmcompressor/ubi9-python-3.11/Dockerfile.cuda:218: micropipenv install --dev && \
Scope
- Only remove direct micropipenv CLI invocations (install/sync/run).
- Keep broader refactors or package removals out of scope for this issue unless already standard elsewhere.
Acceptance criteria
- All micropipenv CLI invocations are removed from the affected Dockerfiles.
- Builds for the affected images remain green in CI.
- Resulting dependency installation approach is consistent with current repository standards for similar images.
- No regressions in runtime behavior for the affected images.
References
- PR: NO-JIRA: skip example Dockerfiles from processing in
dockerfile_fragments.py
#1760 - Review comment requesting this issue: NO-JIRA: skip example Dockerfiles from processing in
dockerfile_fragments.py
#1760 (comment) - Requested by: @jiridanek
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
📋 Backlog