Skip to content

Review TeX Live binary directory naming approach for IBM architectures #2279

@coderabbitai

Description

@coderabbitai

Problem Description

During the review of PR #1179 (Add TeX Live and Pandoc installation for ppc64le), a discussion arose about the approach for handling TeX Live binary directory naming in jupyter/utils/install_texlive.sh.

Context

The current implementation uses $(uname -m)-linux pattern to identify and rename TeX Live binary directories:

mv /usr/local/texlive/bin/"$(uname -m)-linux" /usr/local/texlive/bin/linux

An alternative dynamic discovery approach was initially suggested but deemed overly complicated after discussion.

Discussion Points to Review

  1. Current approach: Using $(uname -m)-linux pattern

    • Simple and follows established TeX Live conventions
    • Reliable across architectures
  2. Alternative approach: Dynamic directory discovery

    • More complex with potential failure points
    • May be unnecessary given TeX Live's consistent naming

Action Items

  • Review the TeX Live binary directory naming approach across all IBM architectures (ppc64le, s390x)
  • Validate that the $(uname -m)-linux pattern works consistently across all supported architectures
  • Consider any edge cases or future compatibility concerns
  • Document the final decision and rationale

References

Context

This review is part of the broader IBM architectures merging process and should be completed as part of the final once-over before merging architecture support changes.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

📋 Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions