-
Notifications
You must be signed in to change notification settings - Fork 130
Open
Description
Description
In jupyter/minimal/ubi9-python-3.12/Dockerfile.konflux.rocm, there is a duplicate RUN block (lines 108-113) that repeats the same chmod -R g+w and fix-permissions commands already executed in lines 101-103.
Current Code
Lines 108-113 contain:
# Fix permissions to support pip in Openshift environments
RUN /bin/bash <<'EOF'
set -Eeuxo pipefail
chmod -R g+w /opt/app-root/lib/python3.12/site-packages
fix-permissions /opt/app-root -P
EOFThese exact commands are already present in the preceding RUN heredoc (lines 101-103), making this second block redundant.
Impact
- Creates an unnecessary extra image layer
- Duplicates permission-fixing operations that were already completed
Suggested Fix
Remove lines 108-113 entirely, keeping only the original permission fixes inside the main RUN heredoc.
References
- PR: RHAIENG-3346, RHAIENG-3349: chore(Dockerfile.konflux): bring over the Dockerfile.konflux files from RHDS to ODHย #3000
- Original finding: RHAIENG-3346, RHAIENG-3349: chore(Dockerfile.konflux): bring over the Dockerfile.konflux files from RHDS to ODHย #3000 (comment)
- Requested by: @jiridanek
This code was imported from RHDS as-is, so the fix is tracked here for future cleanup.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
๐ Backlog