Skip to content

Commit 23ec8d0

Browse files
committed
Further small updates
1 parent 9cbb378 commit 23ec8d0

4 files changed

+20
-7
lines changed

assemblies/enabling-external-resource-access-for-lmeval-jobs.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ ifdef::context[:parent-context: {context}]
77
[role='_abstract']
88
LMEval Jobs do not allow internet access or remote code execution by default. When configuring an `LMEvalJob`, it may require access to external resources, for example task datasets and model tokenizers, usually hosted on link:https://huggingface.co[Hugging Face]. If you trust the source and have reviewed the content of these artifacts, `LMEvalJob` can be configured to automatically download them.
99

10-
Follow the steps below to enable online access and remote code execution for LMEval Jobs. Choose to update these settings by using either the CLI or in the console.
10+
Follow the steps below to enable online access and remote code execution for LMEval Jobs. Choose to update these settings by using either the CLI or in the console. Enable one or both settings according to your needs.
1111

1212
include::modules/updating-lmeval-job-configuration-using-the-cli.adoc[leveloffset=+1]
1313

modules/setting-up-lmeval.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ You can configure the following properties for LM-Eval:
7676
| true
7777
| Whether LMEval jobs can set the online mode to `on` to access artifacts (models, datasets, tokenizers) from the internet.
7878
79-
| `lmes-code-execution`
79+
| `lmes-allow-code-execution`
8080
| true
8181
| Determines whether LMEval jobs can set the `trust remote code` mode to `on`.
8282

modules/updating-lmeval-job-configuration-using-the-cli.adoc

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ ifdef::context[:parent-context: {context}]
66
= Updating LMEval Job configuration using the CLI
77

88
[role='_abstract']
9-
Follow these steps to enable online access (`allowOnline`) and remote code execution (`allowCodeExecution`) modes in the CLI for LMEval Jobs.
9+
Follow these steps to enable online access (`allowOnline`) and remote code execution (`allowCodeExecution`) modes using the CLI for LMEval Jobs.
1010

1111
[IMPORTANT]
1212
====
@@ -51,7 +51,7 @@ If the `opendatahub.io/managed` annotation does not exist, the default value is
5151
| `false`
5252
| Allows the user to manage the TrustyAI operator.
5353
|===
54-
. Update the settings for the TrustyAI operator to enable external connectivity and remote code execution:
54+
. Update the settings for the TrustyAI operator to enable external connectivity or remote code execution, or both:
5555
+
5656
[source,sh]
5757
----
@@ -74,10 +74,23 @@ oc patch configmap trustyai-service-operator-config -n redhat-ods-applications \
7474
| `false`
7575
| Allows execution of code downloaded alongside datasets or tokenizers.
7676
|===
77-
7877
. Restart the TrustyAI operator to apply the configuration changes:
79-
78+
+
79+
[source,sh]
80+
----
81+
oc rollout restart deployment trustyai-service-operator-controller-manager -n redhat-ods-applications
82+
----
83+
. Set the flags on your `LMEvalJob` resource:
84+
+
8085
[source,sh]
8186
----
8287
oc rollout restart deployment trustyai-service-operator-controller-manager -n redhat-ods-applications
8388
----
89+
. Enable online access and/or code execution on the specific `LMEvalJob`:
90+
+
91+
[source,sh]
92+
----
93+
# Patch an existing job (example name: example-lmeval)
94+
oc patch lmevaljob example-lmeval -n <user-or-target-namespace> \
95+
--type merge -p '{"spec":{"allowOnline":true,"allowCodeExecution":true}}'
96+
----

modules/updating-lmeval-job-configuration-using-the-console.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ lmes-allow-code-execution: true
5050
--
5151
Each LMEval Job must explicitly be set to allow online access and code execution.
5252
--
53-
. Add the following fields to the `LMEvalJob` custom resource to enable online access in the LMEvalJob custom resource:
53+
. Add the following fields to the `LMEvalJob` to enable online access and code execution for this job:
5454

5555
[source,yaml]
5656
----

0 commit comments

Comments
 (0)