Skip to content

Commit 514616b

Browse files
authored
odh-23178-3 feature store - peer review (#894)
1 parent cd763fd commit 514616b

8 files changed

+16
-16
lines changed

assemblies/customizing-your-feature-store-configuration.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@
33
ifdef::context[:parent-context: {context}]
44

55
[id="customizing-your-feature-store-configuration_{context}"]
6-
= Customizing your feature store configuration
6+
= Customizing your Feature Store configuration
77

88
[role='_abstract']
9-
Optionally, you can apply the following configurations to your feature store instance:
9+
Optionally, you can apply the following configurations to your Feature Store instance:
1010

1111
* Configure an offline store
1212
* Configure an online store
1313
* Configure the feature registry
1414
* Configure persistent volume claims (PVCs)
1515
* Configure role-based access control (RBAC)
1616

17-
The examples in the following sections describe how to customize a feature store instance by creating a new custom resource definition (CRD). Alternatively, you can customize an existing feature instance as described in _Editing an existing feature store instance_.
17+
The examples in the following sections describe how to customize a Feature Store instance by creating a new custom resource definition (CRD). Alternatively, you can customize an existing feature instance as described in _Editing an existing Feature Store instance_.
1818

1919
For more information about how you can customize your feature store configuration, see the
2020
link:https://github.com/feast-dev/feast/blob/stable/infra/feast-operator/docs/api/markdown/ref.md[Feast API documentation^].

modules/configuring-an-offline-store.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
= Configuring an offline store
55

66
[role='_abstract']
7-
When you create a feature store instance that uses the minimal configuration, by default, Feature Store uses a SQLite file-based store for the offline store.
7+
When you create a Feature Store instance that uses the minimal configuration, by default, Feature Store uses a SQLite file-based store for the offline store.
88

99
The example in the following procedure shows how to configure DuckDB for the offline store.
1010

modules/configuring-an-online-store.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
= Configuring an online store
55

66
[role='_abstract']
7-
When you create a feature store instance using the minimal configuration, by default, the online store is a SQLite database.
7+
When you create a Feature Store instance using the minimal configuration, by default, the online store is a SQLite database.
88

99
The example in the following procedure shows how to configure a PostgreSQL database for the online store.
1010

modules/creating-a-feature-store-instance-in-a-data-science-project.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
:_module-type: PROCEDURE
22

33
[id="creating-a-feature-store-instance-in-a-data-science-project_{context}"]
4-
= Creating a feature store instance in a data science project
4+
= Creating a Feature Store instance in a data science project
55

66
[role='_abstract']
77
You can add an instance of Feature Store to a data science project by creating a custom resource definition (CRD) in the OpenShift console.
@@ -65,7 +65,7 @@ spec:
6565
+
6666
The `spec.feastProjectDir` references a Feature Store project that is in the Git repository for a Credit Store tutorial.
6767

68-
. Optionally, change the `metadata.name` for the feature store instance.
68+
. Optionally, change the `metadata.name` for the Feature Store instance.
6969
. Optionally, edit `feastProject`, which is the namespace for organizing your Feature Store instance. Note that this project is not the {productname-short} data science project.
7070

7171
. Click *Create*.
@@ -154,10 +154,10 @@ The `feature_store.yaml` file defines the following components:
154154

155155
* *entity_key_serialization_version* - Specifies the serialization scheme that Feature Store uses when writing data to the online store.
156156

157-
*NOTE:* Although the `offline_store` location is not included in the `feature_store.yaml` file, the feature store instance uses a DASK file-based offline store. In the `feature_store.yaml` file, the registry type is `file` but it uses a simple SQLite database.
157+
*NOTE:* Although the `offline_store` location is not included in the `feature_store.yaml` file, the Feature Store instance uses a DASK file-based offline store. In the `feature_store.yaml` file, the registry type is `file` but it uses a simple SQLite database.
158158

159159
.Next steps
160160

161-
* Optionally, you can customize the default configurations for the offline store, online store, or registry by editing the YAML configuration for the Feature Store CR, as described in _Customizing your feature store configuration_.
161+
* Optionally, you can customize the default configurations for the offline store, online store, or registry by editing the YAML configuration for the Feature Store CR, as described in _Customizing your Feature Store configuration_.
162162

163163
* Give your ML engineers and data scientists access to the data science project so that they can create a workbench. and provide them with a copy of the `feature_store.yaml` file so that they can add it to their workbench IDE, such as Jupyter.

modules/editing-an-existing-feature-store-instance.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
:_module-type: PROCEDURE
22

33
[id="editing-an-existing-feature-store-instance_{context}"]
4-
= Editing an existing feature store instance
4+
= Editing an existing Feature Store instance
55

66
[role='_abstract']
7-
The examples in this document describe how to customize a feature store instance by creating a new custom resource definition (CRD). Alternatively, you can customize an existing feature instance.
7+
The examples in this document describe how to customize a Feature Store instance by creating a new custom resource definition (CRD). Alternatively, you can customize an existing feature instance.
88

99
.Prerequisites
1010

1111
* You have cluster administrator privileges for your {openshift-platform} cluster.
1212

13-
* You have created a feature store instance, as described in _Deploying a feature store instance in a data science project_.
13+
* You have created a Feature Store instance, as described in _Deploying a Feature Store instance in a data science project_.
1414

1515
.Procedure
1616

@@ -23,4 +23,4 @@ The examples in this document describe how to customize a feature store instance
2323

2424
.Verification
2525

26-
The feature store instance CRD deploys successfully.
26+
The Feature Store instance CRD deploys successfully.

modules/retrieving-online-features-for-model-inference.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ features=feature_service,
6363

6464
.Verification
6565

66-
When you run the `feast` commands, you should see output similar to the following"
66+
When you run the `feast` commands, you should see output similar to the following:
6767

6868
.Example output
6969
----

modules/specifying-files-to-ignore.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
When you run the `feast apply` command, Feature Store reads all Python files recursively, including Python files in subdirectories, even if the Python files do not contain feature definitions.
77

8-
If you have Python files, such as imperative scripts, in your registry folder that you want Feature Store to ignore when you run the feast apply command, you should create a `.feastignore` file and add a list of paths to all files that you want Feature Store to ignore.
8+
If you have Python files, such as imperative scripts, in your registry folder that you want Feature Store to ignore when you run the feast apply command, you should create a `.feastignore` file and add a list of paths to all files that you want Feature Store to ignore.
99

1010
.Example .feastignore file
1111
----

modules/viewing-feature-store-objects-in-the-web-based-ui.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ You can use the Feature Store Web UI to view all registered features, data sourc
1313

1414
* You have enabled the Feature Store component, as described in _Enabling the Feature Store component_.
1515

16-
* You have created a Feature Store CRD, as described in _Creating a feature store instance in a data science project_.
16+
* You have created a Feature Store CRD, as described in _Creating a Feature Store instance in a data science project_.
1717

1818
.Procedure
1919

0 commit comments

Comments
 (0)