Skip to content

Commit 62a1f79

Browse files
committed
UPdated to address peer review comments
1 parent 1c15d99 commit 62a1f79

4 files changed

+7
-7
lines changed

assemblies/enabling-external-resource-access-for-lmeval-jobs.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ Follow the steps below to enable online access and remote code execution for LME
1111

1212
include::modules/updating-lmeval-job-configuration-using-the-cli.adoc[leveloffset=+1]
1313

14-
include::modules/updating-lmeval-job-configuration-using-the-console.adoc[leveloffset=+1]
14+
include::modules/updating-lmeval-job-configuration-using-the-web-console.adoc[leveloffset=+1]
1515

modules/setting-up-lmeval.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,5 +85,5 @@ After updating the settings in the `ConfigMap`, restart the operator to apply th
8585
8686
[IMPORTANT]
8787
--
88-
The `allowOnline` and `allowCodeExecution` settings are *disabled* by default at the operator level in {productname-long}. LMEval jobs do not have internet access or permission to run any externally downloaded code unless explicitly enabled.
88+
The `allowOnline` and `allowCodeExecution` settings are *disabled* by default at the operator level in {productname-long}. LMEval jobs do not allow internet access or permission to run any externally downloaded code unless explicitly enabled.
8989
--

modules/updating-lmeval-job-configuration-using-the-cli.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Enabling online access or code execution involves a security risk. Only use thes
1818
* You have cluster administrator privileges for your {productname-long} cluster.
1919

2020
ifndef::upstream[]
21-
* You have downloaded and installed the OpenShift command-line interface (CLI). See link:https://docs.redhat.com/en/documentation/openshift_container_platform/{ocp-latest-version}/html/cli_tools/openshift-cli-oc#installing-openshift-cli[Installing the OpenShift CLI^].
21+
* You have downloaded and installed the {productname-short} command-line interface (CLI). See link:https://docs.redhat.com/en/documentation/openshift_container_platform/{ocp-latest-version}/html/cli_tools/openshift-cli-oc#installing-openshift-cli[Installing the OpenShift CLI^].
2222
endif::[]
2323

2424
.Procedure

modules/updating-lmeval-job-configuration-using-the-console.adoc renamed to modules/updating-lmeval-job-configuration-using-the-web-console.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
:_module-type: PROCEDURE
22

33
ifdef::context[:parent-context: {context}]
4-
[id="updating-lmeval-job-configuration-using-the-console_{context}"]
5-
= Updating LMEval job configuration using the console
4+
[id="updating-lmeval-job-configuration-using-the-web-console_{context}"]
5+
= Updating LMEval job configuration using the web console
66

77
[role='_abstract']
8-
Follow these steps to enable online access (`allowOnline`) and remote code execution (`allowCodeExecution`) modes through the {productname-short} console for LMEval jobs.
8+
Follow these steps to enable online access (`allowOnline`) and remote code execution (`allowCodeExecution`) modes through the {productname-short} web console for LMEval jobs.
99

1010
[IMPORTANT]
1111
====
@@ -50,7 +50,7 @@ lmes-allow-code-execution: "true"
5050
--
5151
Each LMEval job must explicitly be set to allow online access and code execution.
5252
--
53-
. Ensure that the following fields are set to 'true' to enable online access and code execution for this job when writing your `LMEvalJob` custom resource:
53+
. Ensure that the following fields are set to `true` to enable online access and code execution for this job when writing your `LMEvalJob` custom resource:
5454
+
5555
[source,yaml]
5656
----

0 commit comments

Comments
 (0)