amend

Signed-off-by: Aidan Reilly <[email protected]>

Author: aireilly

.github/workflows/check-links.yml

@@ -17,53 +17,17 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y asciidoctor
 
-      - name: Make script executable
-        run: chmod +x scripts/check-links.sh
+      - name: Make scripts executable
+        run: |
+          chmod +x scripts/check-links.sh
+          chmod +x scripts/check-modified.sh
 
       - name: Fetch base branch
         run: git fetch origin main
 
       - name: Check links in modified files
         shell: bash
         run: |
-          FILES=$(git diff --name-only origin/main...HEAD --diff-filter=d -- "*.adoc")
-
-          check_updated_assemblies () {
-            MODULES=$(echo "$FILES" | grep '^modules/.*\.adoc$')
-            ASSEMBLIES=$(echo "$FILES" | grep '^assemblies/.*\.adoc$')
-            BOOKS=$(echo "$FILES" | grep -E '^[^/]+\.adoc$')
-
-            UPDATED_BOOKS=()
-
-            if [ -n "$MODULES" ]; then
-              while IFS= read -r module; do
-                UPDATED_BOOKS+=( $(grep -rnwl . --include="*.adoc" --exclude-dir={_artifacts,modules,assemblies} -e "$(basename "$module")") )
-                UPDATED_BOOKS+=( $(grep -rnwl assemblies --include="*.adoc" --exclude-dir={_artifacts,modules} -e "$(basename "$module")") )
-              done <<< "$MODULES"
-            fi
-
-            if [ -n "$ASSEMBLIES" ]; then
-              while IFS= read -r assembly; do
-                UPDATED_BOOKS+=( $(grep -rnwl . --include="*.adoc" --exclude-dir={_artifacts,modules,assemblies} -e "$(basename "$assembly")") )
-              done <<< "$ASSEMBLIES"
-            fi
-
-            if [ -n "$BOOKS" ]; then
-              while IFS= read -r book; do
-                UPDATED_BOOKS+=( "$book" )
-              done <<< "$BOOKS"
-            fi
-
-            if [ ${#UPDATED_BOOKS[@]} -eq 0 ]; then
-              echo "No modified books. Skipping link check."
-              exit 0
-            fi
-
-            for f in "${UPDATED_BOOKS[@]}"; do
-              ./scripts/check-links.sh "$f"
-            done
-          }
-
-          check_updated_assemblies
+          scripts/check-modified.sh
 
 

assemblies/upgrading-odh-v2.adoc

@@ -25,4 +25,6 @@ include::modules/requirements-for-upgrading-odh-v2.adoc[leveloffset=+1]
 include::installing-odh-v2.adoc[leveloffset=+1]
 
 ifdef::parent-context[:context: {parent-context}]
-ifndef::parent-context[:!context:]
+ifndef::parent-context[:!context:]
+
+https://docs.redhat.com/derp

customizing-models-with-lab-tuning.adoc

@@ -23,4 +23,3 @@ include::assemblies/preparing-lab-tuning-resources.adoc[leveloffset=+1]
 
 include::assemblies/using-lab-tuning.adoc[leveloffset=+1]
 
-https://docs.redhat.com/derp

scripts/check-links-modified.sh

@@ -0,0 +1,59 @@
+#!/bin/bash
+#
+# Checks for 404 links in a compiled list of modified books
+
+ERRORS=0
+
+FILES=$(git diff --name-only origin/main...HEAD --diff-filter=d -- "*.adoc")
+
+MODULES=$(echo "$FILES" | grep '^modules/.*\.adoc$')
+ASSEMBLIES=$(echo "$FILES" | grep '^assemblies/.*\.adoc$')
+BOOKS=$(echo "$FILES" | grep -E '^[^/]+\.adoc$')
+
+UPDATED_BOOKS=()
+
+if [ -n "$MODULES" ]; then
+  # Check for assemblies and books that include modified modules
+  while IFS= read -r module; do
+    mapfile -t updated_books < <(grep -rnwl . --include="*.adoc" --exclude-dir={_artifacts,modules,assemblies} -e "$(basename "$module")")
+    UPDATED_BOOKS+=( "${updated_books[@]}" )
+
+    mapfile -t updated_books < <(grep -rnwl assemblies --include="*.adoc" --exclude-dir={_artifacts,modules} -e "$(basename "$module")")
+    UPDATED_BOOKS+=( "${updated_books[@]}" )
+  done <<< "$MODULES"
+fi
+
+# Check for books that include modified assemblies
+if [ -n "$ASSEMBLIES" ]; then
+  while IFS= read -r assembly; do
+    mapfile -t results3 < <(grep -rnwl . --include="*.adoc" --exclude-dir={_artifacts,modules,assemblies} -e "$(basename "$assembly")")
+    UPDATED_BOOKS+=( "${results3[@]}" )
+  done <<< "$ASSEMBLIES"
+fi
+
+# Check for directly updated books
+if [ -n "$BOOKS" ]; then
+  while IFS= read -r book; do
+    UPDATED_BOOKS+=( "$book" )
+  done <<< "$BOOKS"
+fi
+
+if [ ${#UPDATED_BOOKS[@]} -eq 0 ]; then
+  echo "No modified books. Skipping link check."
+  exit 0
+fi
+
+# Check links in the compiled list of books
+
+for f in "${UPDATED_BOOKS[@]}"; do
+  echo "Checking: $f"
+  if ! ./scripts/check-links.sh "$f"; then
+    echo "❌ Link check failed for: $f"
+    ERRORS=1
+  fi
+done
+
+if [ "$ERRORS" -ne 0 ]; then
+  echo "One or more link checks failed."
+  exit 1
+fi