Skip to content

Commit f95838e

Browse files
committed
addressing codeRabbit comments for newly updated module setting-up-lmeval
1 parent cb128a0 commit f95838e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

modules/setting-up-lmeval.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ You can configure the following properties for LM-Eval:
4545
4646
| `lmes-detect-device`
4747
| `true/false`
48-
| Detect if there are GPUs available and assign a value for `--device argument` for LM Evaluation Harness. If GPUs are available, the value is `cuda`. If there are no GPUs available, the value is `cpu`.
48+
| Detect if there are GPUs available and assign a value for the `--device argument` for LM Evaluation Harness. If GPUs are available, the value is `cuda`. If there are no GPUs available, the value is `cpu`.
4949
5050
| `lmes-pod-image`
5151
| `quay.io/trustyai/ta-lmes-job:latest`
@@ -72,11 +72,11 @@ You can configure the following properties for LM-Eval:
7272
| The interval to check the job pod for an evaluation job.
7373
7474
| `lmes-allow-online`
75-
| false
75+
| `false`
7676
| Whether LMEval jobs can set the online mode to `on` to access artifacts (models, datasets, tokenizers) from the internet.
7777
7878
| `lmes-allow-code-execution`
79-
| false
79+
| `false`
8080
| Determines whether LMEval jobs can set the `trust remote code` mode to `on`.
8181
8282
|===

modules/updating-lmeval-job-configuration-using-the-cli.adoc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ oc rollout restart deployment trustyai-service-operator-controller-manager -n re
8686
+
8787
[source,sh]
8888
----
89-
oc patch lmevaljobs example-lmeval -n <user-or-target-namespace > \
89+
oc patch lmevaljobs example-lmeval -n <user-or-target-namespace> \
9090
--type merge -p '{"spec":{"allowOnline":true,"allowCodeExecution":true}}'
91-
oc get lmevaljobs example-lmeval -n <user-or-target-namespace > \
91+
oc get lmevaljobs example-lmeval -n <user-or-target-namespace> \
9292
-o jsonpath='{.spec.allowOnline}{"\n"}{.spec.allowCodeExecution}{"\n"}'
9393
----
9494

@@ -100,6 +100,7 @@ apiVersion: trustyai.opendatahub.io/v1alpha1
100100
kind: LMEvalJob
101101
metadata:
102102
name: example-lmeval
103+
namespace: <your-namespace>
103104
spec:
104105
allowOnline: true
105106
allowCodeExecution: true

0 commit comments

Comments
 (0)