Tweaks as a result of QE feedback

Author: BSynRedhat

modules/setting-up-lmeval.adoc

@@ -16,7 +16,6 @@ The following information explains how to create an `LMEvalJob` custom resource
 
 ifdef::upstream[]
 [NOTE]
-
 --
 LM-Eval is only available in the latest community builds. To use LM-Eval on {productname-long}, ensure that you use ODH 2.20 or later versions and add the following `devFlag` to your `DataScienceCluster` resource:
 [source]
@@ -84,21 +83,7 @@ You can configure the following properties for LM-Eval:
 
 After updating the settings in the `ConfigMap`, restart the operator to apply the new values.
 
-// Notes on the 'allow online' setting and patches 
-
-// upstream - allowOnline setting is enabled; end-user can disable if they wish.
-ifdef::upstream[]
-[IMPORTANT]
---
-The `allowOnline` setting is enabled by default in {productname-long}. Using `allowOnline` gives the job permissions to automatically download artifacts from external sources. Change this setting to `false` if you do not want LM-Eval to access external sources.
---
-endif::[]
-
-// downstream - allowOnline is disabled; end-user needs include a patch in the ConfigMap in order to enable it.
-
-ifndef::upstream[]
 [IMPORTANT]
 --
 The `allowOnline` and `allowCodeExecution` settings are *disabled* by default at the operator level in {productname-long}. LMEval jobs do not have internet access or permission to run any externally downloaded code unless explicitly enabled.
 --
-endif::[]

modules/updating-lmeval-job-configuration-using-the-cli.adoc

@@ -59,7 +59,7 @@ oc patch configmap trustyai-service-operator-config -n redhat-ods-applications \
 --type merge -p '{"data":{"lmes-allow-online":"true","lmes-allow-code-execution":"true"}}'
 ----
 +
-.trustyai-service-operator-config	configuration keys for LMEval job access
+.trustyai-service-operator-config configuration keys for LMEval job access
 [cols="3,2,5", options="header"]
 |===
 | ConfigMap Key
@@ -80,19 +80,30 @@ oc patch configmap trustyai-service-operator-config -n redhat-ods-applications \
 ----
 oc rollout restart deployment trustyai-service-operator-controller-manager -n redhat-ods-applications
 ----
-. Set the flags on your `LMEvalJob` resource:
-+
-[source,sh]
-----
-oc rollout restart deployment trustyai-service-operator-controller-manager -n redhat-ods-applications
-----
 . Enable online access or code execution or both on specific `LMEvalJob` resources: 
+
+.. For LMEval Jobs that already exist, apply the following patch: 
 +
 [source,sh]
 ----
-oc patch lmevaljobs example-lmeval -n <user-or-target-namespace> \
+oc patch lmevaljobs example-lmeval -n <user-or-target-namespace > \
   --type merge -p '{"spec":{"allowOnline":true,"allowCodeExecution":true}}'
-
-oc get lmevaljobs example-lmeval -n <user-or-target-namespace> \
+oc get lmevaljobs example-lmeval -n <user-or-target-namespace > \
   -o jsonpath='{.spec.allowOnline}{"\n"}{.spec.allowCodeExecution}{"\n"}'
 ----
+
+.. For new LMEval Jobs, apply a YAML that includes the following fields: 
+[source,yaml]
+----
+apiVersion: trustyai.opendatahub.io/v1alpha1
+kind: LMEvalJob
+metadata:
+  name: example-lmeval
+spec:
+  allowOnline: true
+  allowCodeExecution: true
+
+----
+
+
+

modules/updating-lmeval-job-configuration-using-the-console.adoc

@@ -50,8 +50,8 @@ lmes-allow-code-execution: "true"
 --
 Each LMEval Job must explicitly be set to allow online access and code execution.
 --
-. Add the following fields to the `LMEvalJob` to enable online access and code execution for this job:
-
+. 
+Ensure that the following fields are set to 'true' to enable online access and code execution for this job when writing your `LMEvalJob` custom resource:
 [source,yaml]
 ----
 apiVersion: trustyai.opendatahub.io/v1alpha1