Skip to content

Commit 59b5334

Browse files
committed
fix(ci): fix golint issues
Signed-off-by: Rob Bell <robell@redhat.com>
1 parent 02d01e3 commit 59b5334

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

pkg/rhai/progression/progression_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ func TestPollTrainingProgress(t *testing.T) {
278278
// Create test server
279279
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
280280
w.WriteHeader(tt.responseStatus)
281-
w.Write([]byte(tt.responseBody))
281+
_, _ = w.Write([]byte(tt.responseBody))
282282
}))
283283
defer server.Close()
284284

@@ -1762,7 +1762,3 @@ func ptrInt(i int) *int {
17621762
func ptrFloat64(f float64) *float64 {
17631763
return &f
17641764
}
1765-
1766-
func ptrString(s string) *string {
1767-
return &s
1768-
}

test/e2e/rhai/progression_e2e_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@ const (
4343
interval = 2 * time.Second
4444
consistentDuration = 8 * time.Second
4545
wrapperTestRuntime = "wrapper-test-runtime"
46-
47-
// SDK poll interval constraints (from kubeflow/trainer SDK)
48-
// TransformersTrainer.metrics_poll_interval_seconds enforces 5-300 range
49-
minSDKPollIntervalSeconds = 5 // Minimum: 5 seconds (prevents excessive controller load)
50-
maxSDKPollIntervalSeconds = 300 // Maximum: 300 seconds (5 minutes, keeps tracking responsive)
51-
defaultPollIntervalSeconds = 30 // Default: 30 seconds (balanced)
5246
)
5347

5448
// loadRuntimeFromFile loads TrainingRuntime from YAML file and sets namespace

0 commit comments

Comments
 (0)