Skip to content

Commit 197f101

Browse files
tjohnson31415dtrifiro
authored andcommitted
fix package level logger name
Signed-off-by: Travis Johnson <[email protected]>
1 parent 555b303 commit 197f101

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/vllm_tgis_adapter/__main__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919

2020
from .grpc import run_grpc_server
2121
from .http import run_http_server
22-
from .logging import init_logger
22+
from .logging import DEFAULT_LOGGER_NAME, init_logger
2323
from .tgis_utils.args import EnvVarArgumentParser, add_tgis_args, postprocess_tgis_args
2424
from .utils import check_for_failed_tasks, write_termination_log
2525

2626
if TYPE_CHECKING:
2727
import argparse
2828

29-
logger = init_logger("vllm-tgis-adapter")
29+
logger = init_logger(DEFAULT_LOGGER_NAME)
3030

3131

3232
async def start_servers(args: argparse.Namespace) -> None:

src/vllm_tgis_adapter/logging.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,18 @@
55
init_logger, # noqa: F401
66
)
77

8+
DEFAULT_LOGGER_NAME = __name__.split(".")[0]
9+
810
config = {**DEFAULT_LOGGING_CONFIG}
911

10-
config["formatters"]["vllm_tgis_adapter"] = DEFAULT_LOGGING_CONFIG["formatters"]["vllm"]
12+
config["formatters"][DEFAULT_LOGGER_NAME] = DEFAULT_LOGGING_CONFIG["formatters"]["vllm"]
1113

1214
handler_config = DEFAULT_LOGGING_CONFIG["handlers"]["vllm"]
13-
handler_config["formatter"] = "vllm_tgis_adapter"
14-
config["handlers"]["vllm_tgis_adapter"] = handler_config
15+
handler_config["formatter"] = DEFAULT_LOGGER_NAME
16+
config["handlers"][DEFAULT_LOGGER_NAME] = handler_config
1517

1618
logger_config = DEFAULT_LOGGING_CONFIG["loggers"]["vllm"]
17-
logger_config["handlers"] = ["vllm_tgis_adapter"]
18-
config["loggers"]["vllm_tgis_adapter"] = logger_config
19+
logger_config["handlers"] = [DEFAULT_LOGGER_NAME]
20+
config["loggers"][DEFAULT_LOGGER_NAME] = logger_config
1921

2022
logging.config.dictConfig(config)

src/vllm_tgis_adapter/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ def write_termination_log(msg: str, file: str = "/dev/termination-log") -> None:
2626
# Ignore any errors writing to the termination logfile.
2727
# Users can fall back to the stdout logs, and we don't want to pollute
2828
# those with an error here.
29-
from .logging import init_logger
29+
from .logging import DEFAULT_LOGGER_NAME, init_logger
3030

31-
logger = init_logger("vllm-tgis-adapter")
31+
logger = init_logger(DEFAULT_LOGGER_NAME)
3232
logger.exception("Unable to write termination logs to %s", file)
3333

3434

0 commit comments

Comments
 (0)