Skip to content

Comments

refactor(pdf_parse): improve character spacing handling in PDF text extraction#1386

Merged
myhloli merged 1 commit intoopendatalab:devfrom
myhloli:fix-char-without-space
Jan 2, 2025
Merged

refactor(pdf_parse): improve character spacing handling in PDF text extraction#1386
myhloli merged 1 commit intoopendatalab:devfrom
myhloli:fix-char-without-space

Conversation

@myhloli
Copy link
Collaborator

@myhloli myhloli commented Jan 2, 2025

  • Update the logic for inserting spaces between characters
  • Consider the next character's position instead of the previous one
  • Adjust the spacing threshold to 25% of the average character width
  • Ignore spaces at the end of lines to prevent double spaces

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

…xtraction

- Update the logic for inserting spaces between characters- Consider the next character's position instead of the previous one
- Adjust the spacing threshold to 25% of the average character width
- Ignore spaces at the end of lines to prevent double spaces
@myhloli myhloli merged commit 26f8cba into opendatalab:dev Jan 2, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
@myhloli
Copy link
Collaborator Author

myhloli commented Jan 2, 2025

#1385

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant