Skip to content

Commit b9987af

Browse files
fix(Table): "no records" label is always visible (#258)
1 parent 2f2b663 commit b9987af

File tree

3 files changed

+30
-12
lines changed

3 files changed

+30
-12
lines changed

packages/visualizations/src/components/Table/Body.svelte

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,17 @@
11
<script lang="ts">
22
import type { Column, TableData } from './types';
33
import Cell, { LoadingCell } from './Cell';
4+
import EmptyRow from './EmptyRow.svelte';
45
56
export let loadingRowsNumber: number | null;
67
export let columns: Column[];
78
export let records: TableData | undefined;
8-
export let emptyStateLabel = 'No records found...';
9+
export let emptyStateLabel: string | undefined;
910
</script>
1011

1112
<tbody>
1213
{#if records?.length === 0 && !loadingRowsNumber}
13-
<tr>
14-
<td colspan={columns.length}>
15-
<em>{emptyStateLabel}</em>
16-
</td>
17-
</tr>
14+
<EmptyRow label={emptyStateLabel} />
1815
{/if}
1916
{#if loadingRowsNumber}
2017
{#each Array(loadingRowsNumber) as _}
@@ -43,10 +40,4 @@
4340
:global(.ods-dataviz--default) tr:last-child {
4441
border-bottom: none;
4542
}
46-
47-
:global(.ods-dataviz--default) em {
48-
text-align: center;
49-
width: 100%;
50-
display: block;
51-
}
5243
</style>
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
<script lang="ts">
2+
export let label = 'No records found...';
3+
</script>
4+
5+
<tr>
6+
<td>
7+
<em>{label}</em>
8+
</td>
9+
</tr>
10+
11+
<style lang="scss">
12+
$row-height: 48px;
13+
tr {
14+
height: $row-height;
15+
}
16+
td {
17+
box-sizing: border-box;
18+
position: absolute;
19+
left: 0;
20+
right: 0;
21+
height: $row-height;
22+
display: flex;
23+
align-items: center;
24+
justify-content: center;
25+
}
26+
</style>

packages/visualizations/src/components/Table/TableCard.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
margin-bottom: var(--spacing-100);
4848
overflow: hidden;
4949
background-color: var(--background-color);
50+
position: relative;
5051
}
5152
:global(.ods-dataviz--default) div {
5253
max-width: 100%;

0 commit comments

Comments
 (0)