Fail pipeline for missing version when deploying to Q, P environments (#1248)

Fail the pipeline when no version specified for a Deploy to Q, P environments.

Author: valituguran

CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Changed
 
 ### Fixed
+* Fail the pipeline when no version specified for a deploy to Q, P ([#1248](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1248))
 * Fix Tailor deployment drifts for D, Q envs ([#1055](https://github.com/opendevstack/ods-jenkins-shared-library/pull/1055))
 
 ## [4.11.0] - 2025-12-03

vars/odsOrchestrationPipeline.groovy

@@ -54,7 +54,6 @@ def call(Map config) {
     def repos = []
 
     logger.startClocked('orchestration-master-node')
-
     node('master') {
         try {
             logger.debugClocked('orchestration-master-node')
@@ -99,28 +98,29 @@ def call(Map config) {
         } catch (Exception e) {
             logger.error("Exception catched in the pipeline execution: ${e.message}")
             uploadResourcesToNexus(steps, project, logger)
-        }
-    }
-
-    logger.resetStopwatch()
-    project.clear()
-    ServiceRegistry.removeInstance()
-    UnirestConfig.shutdown()
-    project = null
-    git = null
-    repos = null
-    steps = null
+            throw e
+        } finally {
+            try {
+                logger.resetStopwatch()
+                project.clear()
+                ServiceRegistry.removeInstance()
+                UnirestConfig.shutdown()
+                project = null
+                git = null
+                repos = null
+                steps = null
 
-    try {
-        new ClassLoaderCleaner().clean(logger, processId)
-        // use the jenkins INTERNAL cleanupHeap method - attention NOTHING can happen after this method!
-        logger.debug("forceClean via jenkins internals....")
-        // Force cleanup of the heap to release memory
-        Method cleanupHeap = currentBuild.getRawBuild().getExecution().class.getDeclaredMethod("cleanUpHeap")
-        cleanupHeap.setAccessible(true)
-        cleanupHeap.invoke(currentBuild.getRawBuild().getExecution(), null)
-    } catch (Exception e) {
-        logger.debug("cleanupHeap err: ${e}")
+                new ClassLoaderCleaner().clean(logger, processId)
+                // use the jenkins INTERNAL cleanupHeap method - attention NOTHING can happen after this method!
+                logger.debug("forceClean via jenkins internals....")
+                // Force cleanup of the heap to release memory
+                Method cleanupHeap = currentBuild.getRawBuild().getExecution().class.getDeclaredMethod("cleanUpHeap")
+                cleanupHeap.setAccessible(true)
+                cleanupHeap.invoke(currentBuild.getRawBuild().getExecution(), null)
+            } catch (Exception e) {
+                logger.debug("cleanupHeap err: ${e}")
+            }
+        }
     }
 }
 
@@ -284,4 +284,4 @@ private NexusService getNexusService(def registry) {
     return nexusService
 }
 
-return this
+return this