types

Author: andiwand

src/htmlcmp/compare_output.py

@@ -17,18 +17,33 @@ class Config:
     thread_local = threading.local()
 
 
-def parse_json(path):
+def parse_json(path: Path):
+    if not isinstance(path, Path):
+        raise TypeError(f"Expected Path, got {type(path)}")
+    if not path.is_file():
+        raise FileNotFoundError(f"File not found: {path}")
+
     with open(path) as f:
         return json.load(f)
 
 
-def compare_json(a, b):
+def compare_json(a: Path, b: Path):
+    if not isinstance(a, Path) or not isinstance(b, Path):
+        raise TypeError("Both arguments must be of type Path")
+    if not a.is_file() or not b.is_file():
+        raise FileNotFoundError("Both arguments must be files")
+
     json_a = json.dumps(parse_json(a), sort_keys=True)
     json_b = json.dumps(parse_json(b), sort_keys=True)
     return json_a == json_b
 
 
-def compare_html(a, b, browser=None, diff_output=None):
+def compare_html(a: Path, b: Path, browser=None, diff_output: Path = None):
+    if not isinstance(a, Path) or not isinstance(b, Path):
+        raise TypeError("Both arguments must be of type Path")
+    if not a.is_file() or not b.is_file():
+        raise FileNotFoundError("Both arguments must be files")
+
     if browser is None:
         browser = get_browser()
     diff, (image_a, image_b) = html_render_diff(a, b, browser=browser)
@@ -41,7 +56,12 @@ def compare_html(a, b, browser=None, diff_output=None):
     return result
 
 
-def compare_files(a, b, **kwargs):
+def compare_files(a: Path, b: Path, **kwargs):
+    if not isinstance(a, Path) or not isinstance(b, Path):
+        raise TypeError("Both arguments must be of type Path")
+    if not a.is_file() or not b.is_file():
+        raise FileNotFoundError("Both arguments must be files")
+
     if filecmp.cmp(a, b):
         return True
     if a.suffix == ".json":
@@ -50,15 +70,25 @@ def compare_files(a, b, **kwargs):
         return compare_html(a, b, **kwargs)
 
 
-def comparable_file(path):
+def comparable_file(path: Path):
+    if not isinstance(path, Path):
+        raise TypeError(f"Expected Path, got {type(path)}")
+    if not path.is_file():
+        raise FileNotFoundError(f"File not found: {path}")
+
     if path.suffix == ".json":
         return True
     if path.suffix == ".html":
         return True
     return False
 
 
-def submit_compare_dirs(a, b, executor, diff_output=None, **kwargs):
+def submit_compare_dirs(a: Path, b: Path, executor, diff_output: Path = None, **kwargs):
+    if not isinstance(a, Path) or not isinstance(b, Path):
+        raise TypeError("Both arguments must be of type Path")
+    if not a.is_dir() or not b.is_dir():
+        raise FileNotFoundError("Both arguments must be directories")
+
     results = {
         "common_dirs": [],
         "common_files": [],
@@ -123,7 +153,16 @@ def compare(path_a, path_b, diff_output):
     return results
 
 
-def print_results(results, a, b, level=0, prefix=""):
+def print_results(
+    results: dict[str, list[Path]], a: Path, b: Path, level: int = 0, prefix: str = ""
+):
+    if not isinstance(a, Path) or not isinstance(b, Path):
+        raise TypeError("Both arguments must be of type Path")
+    if not a.is_dir() or not b.is_dir():
+        raise FileNotFoundError("Both arguments must be directories")
+    if not isinstance(results, dict):
+        raise TypeError("Results must be a dictionary")
+
     prefix_file = prefix + "├── "
     if level == 0:
         print(f"compare dir {a} with {b}")

src/htmlcmp/compare_output_server.py

@@ -8,18 +8,18 @@
 from pathlib import Path
 from concurrent.futures import ThreadPoolExecutor
 
-from compare_output import comparable_file, compare_files
 from flask import Flask, send_from_directory, send_file
 import watchdog.observers
 import watchdog.events
 
+from compare_output import comparable_file, compare_files
 from html_render_diff import get_browser, html_render_diff
 
 
 class Config:
-    path_a = None
-    path_b = None
-    driver = None
+    path_a: Path = None
+    path_b: Path = None
+    driver: str = None
     observer = None
     comparator = None
     browser = None
@@ -46,7 +46,12 @@ def dispatch(self, event):
     def start(self):
         self._observer.start()
 
-        def init_compare(a, b):
+        def init_compare(a: Path, b: Path):
+            if not isinstance(a, Path) or not isinstance(b, Path):
+                raise TypeError("Paths must be of type Path")
+            if not a.is_dir() or not b.is_dir():
+                raise ValueError("Both paths must be directories")
+
             common_path = a / Config.path_a
 
             left = sorted(p.name for p in a.iterdir())
@@ -70,7 +75,7 @@ def join(self):
 
 
 class Comparator:
-    def __init__(self, max_workers):
+    def __init__(self, max_workers: int):
         def initializer():
             browser = getattr(Config.thread_local, "browser", None)
             if browser is None:
@@ -83,7 +88,10 @@ def initializer():
         self._result = {}
         self._future = {}
 
-    def submit(self, path):
+    def submit(self, path: Path):
+        if not isinstance(path, Path):
+            raise TypeError("Path must be of type Path")
+
         if path in self._future:
             try:
                 self._future[path].cancel()
@@ -95,7 +103,14 @@ def submit(self, path):
         self._result[path] = "pending"
         self._future[path] = self._executor.submit(self.compare, path)
 
-    def compare(self, path):
+    def compare(self, path: Path):
+        if not isinstance(path, Path):
+            raise TypeError("Path must be of type Path")
+        if not path.is_file():
+            raise ValueError("Path must be a file")
+        if path not in self._future:
+            raise RuntimeError("Path not submitted for comparison")
+
         browser = getattr(Config.thread_local, "browser", None)
         result = compare_files(
             Config.path_a / path,
@@ -105,12 +120,18 @@ def compare(self, path):
         self._result[path] = "same" if result else "different"
         self._future.pop(path)
 
-    def result(self, path):
+    def result(self, path: Path):
+        if not isinstance(path, Path):
+            raise TypeError("Path must be of type Path")
+
         if path in self._result:
             return self._result[path]
         return "unknown"
 
-    def result_symbol(self, path):
+    def result_symbol(self, path: Path):
+        if not isinstance(path, Path):
+            raise TypeError("Path must be of type Path")
+
         result = self.result(path)
         if result == "pending":
             return "🔄"
@@ -120,7 +141,10 @@ def result_symbol(self, path):
             return "❌"
         return "⛔"
 
-    def result_css(self, path):
+    def result_css(self, path: Path):
+        if not isinstance(path, Path):
+            raise TypeError("Path must be of type Path")
+
         result = self.result(path)
         if result == "pending":
             return "color:blue;"
@@ -136,7 +160,12 @@ def result_css(self, path):
 
 @app.route("/")
 def root():
-    def print_tree(a, b):
+    def print_tree(a: Path, b: Path):
+        if not isinstance(a, Path) or not isinstance(b, Path):
+            raise TypeError("Paths must be of type Path")
+        if not a.is_dir() or not b.is_dir():
+            raise ValueError("Both paths must be directories")
+
         common_path = a / Config.path_a
 
         left = sorted(p.name for p in a.iterdir())
@@ -209,7 +238,10 @@ def print_tree(a, b):
 
 
 @app.route("/compare/<path:path>")
-def compare(path):
+def compare(path: str):
+    if not isinstance(path, str):
+        raise TypeError("Path must be a string")
+
     return f"""<!DOCTYPE html>
 <html>
 <head>
@@ -219,7 +251,7 @@ def compare(path):
 </head>
 <body style="display:flex;flex-flow:row;">
 <div style="display:flex;flex:1;flex-flow:column;margin:5px;">
-  <a href="/file/a/{path}">{Config.path_a /path}</a>
+  <a href="/file/a/{path}">{Config.path_a / path}</a>
   <iframe id="a" src="/file/a/{path}" title="a" frameborder="0" align="left" style="flex:1;"></iframe>
 </div>
 <div style="display:flex;flex:0 0 50px;flex-flow:column;">
@@ -246,7 +278,10 @@ def compare(path):
 
 
 @app.route("/image_diff/<path:path>")
-def image_diff(path):
+def image_diff(path: str):
+    if not isinstance(path, str):
+        raise TypeError("Path must be a string")
+
     diff, _ = html_render_diff(
         Config.path_a / path,
         Config.path_b / path,
@@ -259,7 +294,12 @@ def image_diff(path):
 
 
 @app.route("/file/<variant>/<path:path>")
-def file(variant, path):
+def file(variant: str, path: str):
+    if not isinstance(variant, str) or not isinstance(path, str):
+        raise TypeError("Variant and path must be strings")
+    if variant not in ["a", "b"]:
+        raise ValueError("Variant must be 'a' or 'b'")
+
     variant_root = Config.path_a if variant == "a" else Config.path_b
     return send_from_directory(variant_root, path)
 

src/htmlcmp/html_render_diff.py

@@ -14,13 +14,19 @@
 from selenium.webdriver.support.ui import WebDriverWait
 
 
-def to_url(path):
+def to_url(path: Path):
+    if not isinstance(path, Path):
+        raise TypeError(f"Expected Path, got {type(path)}")
+
     if path.is_file():
         return path.resolve().as_uri()
     return path
 
 
-def screenshot(browser, url):
+def screenshot(browser, url: str):
+    if not isinstance(url, str):
+        raise TypeError(f"Expected str, got {type(url)}")
+
     browser.get(url)
 
     target_find_by = By.TAG_NAME
@@ -49,7 +55,16 @@ def screenshot(browser, url):
     return Image.open(io.BytesIO(png))
 
 
-def get_browser(driver="firefox", max_width=1000, max_height=10000):
+def get_browser(
+    driver: str = "firefox", max_width: int = 1000, max_height: int = 10000
+):
+    if not isinstance(driver, str):
+        raise TypeError(f"Expected str, got {type(driver)}")
+    if not isinstance(max_width, int) or not isinstance(max_height, int):
+        raise TypeError(
+            f"Expected int for max_width and max_height, got {type(max_width)} and {type(max_height)}"
+        )
+
     if driver == "phantomjs":
         browser = webdriver.PhantomJS()
     elif driver == "firefox":
@@ -64,7 +79,12 @@ def get_browser(driver="firefox", max_width=1000, max_height=10000):
     return browser
 
 
-def html_render_diff(a, b, browser):
+def html_render_diff(a: Path, b: Path, browser):
+    if not isinstance(a, Path) or not isinstance(b, Path):
+        raise TypeError("Both arguments must be of type Path")
+    if not a.is_file() or not b.is_file():
+        raise FileNotFoundError("Both arguments must be files")
+
     image_a = screenshot(browser, to_url(a))
     image_b = screenshot(browser, to_url(b))