style: fix quality

Author: kyrylo-kh

credentials/apps/verifiable_credentials/composition/tests/test_schemas.py

@@ -58,9 +58,12 @@ def setUp(self):
             credential_content_type=self.program_credential_content_type,
             credential=self.program_cert,
         )
-        self.program_issuance_line = IssuanceLineFactory(user_credential=self.program_user_credential, subject_id="did:key:test")
-        self.course_issuance_line = IssuanceLineFactory(user_credential=self.course_user_credential, subject_id="did:key:test")
-
+        self.program_issuance_line = IssuanceLineFactory(
+            user_credential=self.program_user_credential, subject_id="did:key:test"
+        )
+        self.course_issuance_line = IssuanceLineFactory(
+            user_credential=self.course_user_credential, subject_id="did:key:test"
+        )
 
     def test_to_representation_program(self):
         data = EducationalOccupationalCredentialSchema(self.program_issuance_line).data

credentials/apps/verifiable_credentials/constants.py

@@ -2,5 +2,6 @@ class CredentialsType:
     """
     Enum to define the type of credentials.
     """
+
     PROGRAM = "programcertificate"
     COURSE = "coursecertificate"

credentials/apps/verifiable_credentials/issuance/models.py

@@ -17,9 +17,9 @@
 from credentials.apps.verifiable_credentials.utils import capitalize_first
 
 from ..composition.utils import get_data_model, get_data_models
+from ..constants import CredentialsType
 from ..settings import vc_settings
 from ..storages.utils import get_storage
-from ..constants import CredentialsType
 
 
 User = get_user_model()
@@ -154,13 +154,15 @@ def credential_description(self):
                 effort_info=effort_portion,
             )
         elif self.credential_content_type == CredentialsType.COURSE:
-            description = _("{credential_type} is granted on course {course_title} completion offered by {organization}, in collaboration with {platform_name}").format(
+            description = _(
+                "{credential_type} is granted on course {course_title} completion offered by {organization}, in collaboration with {platform_name}"  # pylint: disable=line-too-long
+            ).format(
                 credential_type=self.credential_verbose_type,
                 course_title=getattr(self.course, "title", ""),
                 platform_name=self.platform_name,
                 organization=self.user_credential.credential.course_key.org,
             )
-        return capitalize_first(description)
+        return capitalize_first(description)  # pylint: disable=possibly-used-before-assignment
 
     @property
     def credential_narrative(self):
@@ -185,7 +187,7 @@ def credential_narrative(self):
                 organization=self.user_credential.credential.course_key.org,
                 platform_name=self.platform_name,
             )
-        return capitalize_first(narrative)
+        return capitalize_first(narrative)  # pylint: disable=possibly-used-before-assignment
 
     @property
     def credential_content_type(self):

credentials/apps/verifiable_credentials/rest_api/v1/tests/test_views.py

@@ -1,10 +1,10 @@
 import json
 from unittest import mock
 
+from ddt import data, ddt, unpack
 from django.contrib.contenttypes.models import ContentType
 from django.test import TestCase
 from django.urls import reverse
-from ddt import ddt, data, unpack
 from rest_framework import status
 
 from credentials.apps.catalog.tests.factories import (
@@ -89,14 +89,21 @@ def test_get_without_query_params(self):
         self.client.login(username=self.user.username, password=USER_PASSWORD)
         response = self.client.get("/verifiable_credentials/api/v1/credentials/")
         self.assertEqual(response.status_code, 200)
-        self.assertEqual(response.data["program_credentials"], get_user_credentials_data(self.user.username, "programcertificate"))
-        self.assertEqual(response.data["course_credentials"], get_user_credentials_data(self.user.username, "coursecertificate"))
+        self.assertEqual(
+            response.data["program_credentials"], get_user_credentials_data(self.user.username, "programcertificate")
+        )
+        self.assertEqual(
+            response.data["course_credentials"], get_user_credentials_data(self.user.username, "coursecertificate")
+        )
 
     @data(
         ("programcertificate", {"program_credentials": "programcertificate"}, ["course_credentials"]),
         ("coursecertificate", {"course_credentials": "coursecertificate"}, ["program_credentials"]),
-        ("programcertificate,coursecertificate",
-         {"program_credentials": "programcertificate", "course_credentials": "coursecertificate"}, [])
+        (
+            "programcertificate,coursecertificate",
+            {"program_credentials": "programcertificate", "course_credentials": "coursecertificate"},
+            [],
+        ),
     )
     @unpack
     def test_get_with_query_params(self, types, expected_data, not_in_keys):
@@ -105,14 +112,12 @@ def test_get_with_query_params(self, types, expected_data, not_in_keys):
         self.assertEqual(response.status_code, 200)
 
         for key, expected_value in expected_data.items():
-            self.assertEqual(
-                response.data[key], 
-                get_user_credentials_data(self.user.username, expected_value)
-            )
+            self.assertEqual(response.data[key], get_user_credentials_data(self.user.username, expected_value))
 
         for key in not_in_keys:
             self.assertNotIn(key, response.data)
 
+
 class InitIssuanceViewTestCase(SiteMixin, TestCase):
     url_path = reverse("verifiable_credentials:api:v1:credentials-init")
 
@@ -240,7 +245,7 @@ def test_post_valid_request(self, mock_issue):
         mock_issue.return_value = {"verifiable_credential": "test"}
 
         url_path = reverse("verifiable_credentials:api:v1:credentials-issue", args=[str(self.issuance_line.uuid)])
-        data = {"holder": "test-holder-id"}
+        data = {"holder": "test-holder-id"}  # pylint: disable=redefined-outer-name
         response = self.client.post(url_path, json.dumps(data), JSON_CONTENT_TYPE)
         self.assertEqual(response.status_code, status.HTTP_201_CREATED)
         self.assertEqual(response.data, {"verifiable_credential": "test"})
@@ -249,7 +254,7 @@ def test_post_valid_request(self, mock_issue):
     def test_post_invalid_request_raises_validation_error(self, mock_issue):
         self.authenticate_user(self.user)
         mock_issue.side_effect = IssuanceException(detail="Invalid request.")
-        data = {"holder": "test-holder-id"}
+        data = {"holder": "test-holder-id"}  # pylint: disable=redefined-outer-name
         url_path = reverse("verifiable_credentials:api:v1:credentials-issue", args=[str(self.issuance_line.uuid)])
         response = self.client.post(url_path, json.dumps(data), JSON_CONTENT_TYPE)
         self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)

credentials/apps/verifiable_credentials/rest_api/v1/views.py

@@ -57,17 +57,20 @@ def list(self, request, *args, **kwargs):
         Returns:
             response(dict): Information about the user's program credentials
         """
-        types = self.request.query_params.get('types')
+        types = self.request.query_params.get("types")
         response = {}
 
         if types:
-            types = types.split(',')
+            types = types.split(",")
         else:
             types = self.CREDENTIAL_TYPES_MAP.keys()
 
-        for type in types:
-            if type in self.CREDENTIAL_TYPES_MAP:
-                response[self.CREDENTIAL_TYPES_MAP[type]] = get_user_credentials_data(request.user.username, type)
+        for credential_type in types:
+            if credential_type in self.CREDENTIAL_TYPES_MAP:
+                response[self.CREDENTIAL_TYPES_MAP[credential_type]] = get_user_credentials_data(
+                    request.user.username,
+                    credential_type
+                )
 
         return Response(response)
 

credentials/apps/verifiable_credentials/tests/test_utils.py

@@ -90,7 +90,9 @@ def test_get_user_program_credentials_data_one_program(self):
         assert result[0]["username"] == self.program_user_credential.username
         assert result[0]["download_url"] == self.program_user_credential.download_url
         assert result[0]["credential_id"] == self.program_user_credential.credential_id
-        assert result[0]["credential_uuid"] == str(self.program_user_credential.credential.program_uuid).replace("-", "")
+        assert result[0]["credential_uuid"] == str(self.program_user_credential.credential.program_uuid).replace(
+            "-", ""
+        )
         assert result[0]["credential_title"] == self.program_user_credential.credential.program.title
 
     def test_get_user_program_credentials_data_multiple_programs(self):
@@ -114,15 +116,19 @@ def test_get_user_program_credentials_data_multiple_programs(self):
         assert result[0]["username"] == self.program_user_credential.username
         assert result[0]["download_url"] == self.program_user_credential.download_url
         assert result[0]["credential_id"] == self.program_user_credential.credential_id
-        assert result[0]["credential_uuid"] == str(self.program_user_credential.credential.program_uuid).replace("-", "")
+        assert result[0]["credential_uuid"] == str(self.program_user_credential.credential.program_uuid).replace(
+            "-", ""
+        )
         assert result[0]["credential_title"] == self.program_user_credential.credential.program.title
 
         assert result[1]["uuid"] == str(self.program_user_credential2.uuid).replace("-", "")
         assert result[1]["status"] == self.program_user_credential2.status
         assert result[1]["username"] == self.program_user_credential2.username
         assert result[1]["download_url"] == self.program_user_credential2.download_url
         assert result[1]["credential_id"] == self.program_user_credential2.credential_id
-        assert result[1]["credential_uuid"] == str(self.program_user_credential2.credential.program_uuid).replace("-", "")
+        assert result[1]["credential_uuid"] == str(self.program_user_credential2.credential.program_uuid).replace(
+            "-", ""
+        )
         assert result[1]["credential_title"] == self.program_user_credential2.credential.program.title
 
     def test_get_user_course_credentials_data_zero_courses(self):
@@ -164,6 +170,7 @@ def test_non_existing_content_type(self):
         result = get_user_credentials_data(self.user.username, "non_existing_content_type")
         assert result == []
 
+
 class TestGenerateBase64QRCode(TestCase):
     def test_correct_output_format(self):
         result = generate_base64_qr_code("Test Text")

credentials/apps/verifiable_credentials/utils.py

@@ -43,17 +43,19 @@ def get_user_credentials_data(username, model):
             credential_title = credential.credential.title
             credential_org = credential.credential.course_key.org
 
-        data.append({
-            "uuid": credential.uuid.hex,
-            "status": credential.status,
-            "username": credential.username,
-            "download_url": credential.download_url,
-            "credential_id": credential.credential_id,
-            "credential_uuid": credential_uuid ,
-            "credential_title": credential_title,
-            "credential_org": credential_org,
-            "modified_date": credential.modified.date().isoformat(),
-        })
+        data.append(
+            {
+                "uuid": credential.uuid.hex,
+                "status": credential.status,
+                "username": credential.username,
+                "download_url": credential.download_url,
+                "credential_id": credential.credential_id,
+                "credential_uuid": credential_uuid,  # pylint: disable=possibly-used-before-assignment
+                "credential_title": credential_title,  # pylint: disable=possibly-used-before-assignment
+                "credential_org": credential_org,  # pylint: disable=possibly-used-before-assignment
+                "modified_date": credential.modified.date().isoformat(),
+            }
+        )
 
     return data