WIP: fix: disable file buttons while upload in progress

This avoids race conditions and resulting issues, including:

- deleting a file while an upload is in progress
- selecting a new file to upload while another upload is in progress
- submitting the assessment while an upload is in progress
- TODO: deleting a file while submission is in progress

Private-ref: https://tasks.opencraft.com/browse/BB-9938

Author: samuelallan72

openassessment/xblock/static/dist/manifest.json

@@ -4,18 +4,18 @@
   "openassessment-editor-textarea.js.map": "/openassessment-editor-textarea.cbb31e4372be87d437fb.js.map",
   "openassessment-editor-tinymce.js": "/openassessment-editor-tinymce.2a1e66e98a2a1132f633.js",
   "openassessment-editor-tinymce.js.map": "/openassessment-editor-tinymce.2a1e66e98a2a1132f633.js.map",
-  "openassessment-lms.css": "/openassessment-lms.42bdf01af5d117224bc9.css",
-  "openassessment-lms.js": "/openassessment-lms.42bdf01af5d117224bc9.js",
-  "openassessment-lms.css.map": "/openassessment-lms.42bdf01af5d117224bc9.css.map",
-  "openassessment-lms.js.map": "/openassessment-lms.42bdf01af5d117224bc9.js.map",
-  "openassessment-ltr.css": "/openassessment-ltr.0c6318822d5661f0f9ea.css",
-  "openassessment-ltr.js": "/openassessment-ltr.0c6318822d5661f0f9ea.js",
-  "openassessment-ltr.css.map": "/openassessment-ltr.0c6318822d5661f0f9ea.css.map",
-  "openassessment-ltr.js.map": "/openassessment-ltr.0c6318822d5661f0f9ea.js.map",
-  "openassessment-rtl.css": "/openassessment-rtl.c938e1614108d8feb891.css",
-  "openassessment-rtl.js": "/openassessment-rtl.c938e1614108d8feb891.js",
-  "openassessment-rtl.css.map": "/openassessment-rtl.c938e1614108d8feb891.css.map",
-  "openassessment-rtl.js.map": "/openassessment-rtl.c938e1614108d8feb891.js.map",
+  "openassessment-lms.css": "/openassessment-lms.ff602d9a3d17c398701d.css",
+  "openassessment-lms.js": "/openassessment-lms.ff602d9a3d17c398701d.js",
+  "openassessment-lms.css.map": "/openassessment-lms.ff602d9a3d17c398701d.css.map",
+  "openassessment-lms.js.map": "/openassessment-lms.ff602d9a3d17c398701d.js.map",
+  "openassessment-ltr.css": "/openassessment-ltr.97990de9668aaa4cd1d5.css",
+  "openassessment-ltr.js": "/openassessment-ltr.97990de9668aaa4cd1d5.js",
+  "openassessment-ltr.css.map": "/openassessment-ltr.97990de9668aaa4cd1d5.css.map",
+  "openassessment-ltr.js.map": "/openassessment-ltr.97990de9668aaa4cd1d5.js.map",
+  "openassessment-rtl.css": "/openassessment-rtl.19576ab9f81f644cb7fd.css",
+  "openassessment-rtl.js": "/openassessment-rtl.19576ab9f81f644cb7fd.js",
+  "openassessment-rtl.css.map": "/openassessment-rtl.19576ab9f81f644cb7fd.css.map",
+  "openassessment-rtl.js.map": "/openassessment-rtl.19576ab9f81f644cb7fd.js.map",
   "openassessment-studio.js": "/openassessment-studio.b58bb4e55f63dadac6de.js",
   "openassessment-studio.js.map": "/openassessment-studio.b58bb4e55f63dadac6de.js.map",
   "fallback-default.png": "/4620b30a966533ace489dcc7afb151b9.png",

openassessment/xblock/static/dist/openassessment-lms.42bdf01af5d117224bc9.css

@@ -158,24 +158,40 @@ export class ResponseView {
       this.baseView.bindLatexPreview(sel);
 
       const uploadButton = sel.find('.file__upload');
+      const deleteButtons = sel.find('.delete__uploaded__file');
+      const fileInput = sel.find('.submission__answer__upload');
       const spinner = sel.find('.fa-spinner');
+
+      const disableWhileUploading = () => {
+        uploadButton.prop('disabled', true);
+        deleteButtons.prop('disabled', true);
+        fileInput.prop('disabled', true);
+        this.submitEnabled(false);
+        spinner.removeClass('is--hidden');
+      };
+
+      const enableAfterUploading = () => {
+        uploadButton.prop('disabled', false);
+        deleteButtons.prop('disabled', false);
+        fileInput.prop('disabled', false);
+        this.submitEnabled(true);
+        spinner.addClass('is--hidden');
+      };
+
       // Install a click handler for the save button
       uploadButton.click(
         (eventObject) => {
           // Override default form submission
           eventObject.preventDefault();
           $('.submission__answer__display__file', view.element).removeClass('is--hidden');
-          uploadButton.prop('disabled', true);
-          spinner.removeClass('is--hidden');
+          disableWhileUploading();
           if (view.hasAllUploadFiles()) {
             const promise = view.uploadFiles();
             promise.then(() => {
-              uploadButton.prop('disabled', false);
-              spinner.addClass('is--hidden');
+              enableAfterUploading();
             });
           } else {
-            uploadButton.prop('disabled', false);
-            spinner.addClass('is--hidden');
+            enableAfterUploading();
           }
         },
       );