Skip to content

Commit 84554f3

Browse files
committed
fix: update the library scope according to the backend requirements
1 parent f2f0627 commit 84554f3

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/authz-module/data/api.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export type PermissionsByRole = {
1616

1717
// TODO: replece api path once is created
1818
export const getTeamMembers = async (object: string): Promise<TeamMember[]> => {
19-
const { data } = await getAuthenticatedHttpClient().get(getApiUrl(`/api/authz/v1/roles/users?scope=${object}`));
19+
const { data } = await getAuthenticatedHttpClient().get(getApiUrl(`/api/authz/v1/roles/users/?scope=${object}`));
2020
return camelCaseObject(data.results);
2121
};
2222

@@ -32,8 +32,8 @@ export const getLibrary = async (libraryId: string): Promise<LibraryMetadata> =>
3232
};
3333

3434
export const getPermissionsByRole = async (scope: string): Promise<PermissionsByRole[]> => {
35-
const url = new URL(getApiUrl('/api/authz/v1/roles'));
35+
const url = new URL(getApiUrl('/api/authz/v1/roles/'));
3636
url.searchParams.append('scope', scope);
3737
const { data } = await getAuthenticatedHttpClient().get(url);
38-
return camelCaseObject(data);
38+
return camelCaseObject(data.results);
3939
};

src/authz-module/data/hooks.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ describe('usePermissionsByRole', () => {
132132
];
133133

134134
getAuthenticatedHttpClient.mockReturnValue({
135-
get: jest.fn().mockResolvedValue({ data: mockRoles }),
135+
get: jest.fn().mockResolvedValue({ data: { results: mockRoles } }),
136136
});
137137

138138
const wrapper = createWrapper();

src/authz-module/libraries-manager/context.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import { PermissionMetadata, ResourceMetadata, Role } from 'types';
99
import { libraryPermissions, libraryResourceTypes, libraryRolesMetadata } from './constants';
1010

1111
const LIBRARY_TEAM_PERMISSIONS = ['view_library_team', 'manage_library_team'];
12-
const LIBRARY_AUTHZ_SCOPE = 'lib:*';
12+
// Note: This value can change in the future
13+
const LIBRARY_AUTHZ_SCOPE = '*';
1314

1415
export type AppContextType = {
1516
authenticatedUser: {

0 commit comments

Comments
 (0)