Skip to content

Commit 3dac6aa

Browse files
authored
fix: modal exit redirect (#659)
1 parent 4a3d1a1 commit 3dac6aa

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

src/custom-pages/CustomPages.jsx

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import React, { useEffect, useContext, useState } from 'react';
22
import PropTypes from 'prop-types';
3-
import {
4-
Routes, Route, useLocation, useNavigate,
5-
} from 'react-router-dom';
3+
import { Routes, Route, useNavigate } from 'react-router-dom';
64
import { useDispatch, useSelector } from 'react-redux';
75
import { AppContext, PageWrap } from '@edx/frontend-platform/react';
86
import { injectIntl, FormattedMessage, intlShape } from '@edx/frontend-platform/i18n';
@@ -53,13 +51,11 @@ const CustomPages = ({
5351
const [orderedPages, setOrderedPages] = useState([]);
5452
const [currentPage, setCurrentPage] = useState();
5553
const [isOpen, open, close] = useToggle(false);
56-
const [isEditModalOpen, openEditModal, closeEditModal] = useToggle(false);
5754

5855
const courseDetails = useModel('courseDetails', courseId);
5956
document.title = getPageHeadTitle(courseDetails?.name, intl.formatMessage(messages.heading));
6057

6158
const { config } = useContext(AppContext);
62-
const location = useLocation();
6359
const learningCourseURL = `${config.LEARNING_BASE_URL}/course/${courseId}`;
6460

6561
useEffect(() => {
@@ -79,15 +75,14 @@ const CustomPages = ({
7975
dispatch(updatePageOrder(courseId, newPageOrder));
8076
};
8177
const handleEditClose = () => (content) => {
82-
navigate(location.pathname);
78+
navigate(`/course/${courseId}/custom-pages`);
8379
if (!content?.metadata) {
84-
closeEditModal();
80+
setCurrentPage(null);
8581
return;
8682
}
8783
dispatch(updateSingleCustomPage({
8884
blockId: currentPage,
8985
metadata: { displayName: content.metadata.display_name },
90-
onClose: closeEditModal,
9186
setCurrentPage,
9287
}));
9388
};
@@ -192,7 +187,6 @@ const CustomPages = ({
192187
deletePageStatus,
193188
courseId,
194189
setCurrentPage,
195-
openEditModal,
196190
}}
197191
/>
198192
</SortableItem>
@@ -262,7 +256,6 @@ const CustomPages = ({
262256
<PageWrap>
263257
<EditModal
264258
courseId={courseId}
265-
isOpen={isEditModalOpen}
266259
pageId={currentPage}
267260
onClose={handleEditClose}
268261
/>

0 commit comments

Comments
 (0)