fixup! feat: improve collection sidebar

Author: rpenido

src/library-authoring/collections/CollectionDetails.test.tsx

@@ -14,71 +14,20 @@ import {
 } from '../../testUtils';
 import mockResult from '../__mocks__/collection-search.json';
 import { mockContentLibrary } from '../data/api.mocks';
-import * as api from '../data/api';
 import CollectionDetails from './CollectionDetails';
 
 const searchEndpoint = 'http://mock.meilisearch.local/multi-search';
-const mockCollection = {
-  collectionId: mockResult.results[2].hits[0].block_id,
-  collectionNoComponents: 'collection-no-components',
-  collectionMultipleComponents: 'collection-multiple-components',
-  title: mockResult.results[2].hits[0].display_name,
-  description: mockResult.results[2].hits[0].description,
-};
 
 let axiosMock: MockAdapter;
-let mockShowToast: (message: string) => void;
+// let mockShowToast: (message: string) => void;
 
 mockContentSearchConfig.applyMock();
 
 describe('<CollectionDetails />', () => {
   beforeEach(() => {
     const mocks = initializeMocks();
     axiosMock = mocks.axiosMock;
-    mockShowToast = mocks.mockShowToast;
-    return;
-
-    // The Meilisearch client-side API uses fetch, not Axios.
-    fetchMock.post(searchEndpoint, (_url, req) => {
-      const requestData = JSON.parse(req.body?.toString() ?? '');
-      const query = requestData?.queries[0]?.q ?? '';
-      const mockResultCopy = cloneDeep(mockResult);
-      // We have to replace the query (search keywords) in the mock results with the actual query,
-      // because otherwise Instantsearch will update the UI and change the query,
-      // leading to unexpected results in the test cases.
-      mockResultCopy.results[0].query = query;
-      mockResultCopy.results[1].query = query;
-      mockResultCopy.results[2].query = query;
-      // And fake the required '_formatted' fields; it contains the highlighting <mark>...</mark> around matched words
-      // eslint-disable-next-line no-underscore-dangle, no-param-reassign
-      mockResultCopy.results[0]?.hits.forEach((hit) => { hit._formatted = { ...hit }; });
-      const collectionQueryId = requestData?.queries[2]?.filter[2]?.split('block_id = "')[1].split('"')[0];
-      mockResultCopy.results[0].description = requestData?.queries[2]?.filter[2];
-      switch (collectionQueryId) {
-        case mockCollection.collectionNoComponents:
-          mockResultCopy.results[1].facetDistribution.block_type = {};
-          break;
-        case mockCollection.collectionMultipleComponents:
-          mockResultCopy.results[1].facetDistribution.block_type = {
-            annotatable: 1,
-            chapter: 2,
-            discussion: 3,
-            drag_and_drop_v2: 4,
-            html: 5,
-            library_content: 6,
-            openassessment: 7,
-            problem: 8,
-            sequential: 9,
-            vertical: 10,
-            video: 11,
-            choiceresponse: 12,
-          };
-          break;
-        default:
-          break;
-      }
-      return mockResultCopy;
-    });
+    // mockShowToast = mocks.mockShowToast;
   });
 
   afterEach(() => {
@@ -87,8 +36,7 @@ describe('<CollectionDetails />', () => {
     fetchMock.mockReset();
   });
 
-  const renderCollectionDetails = async (collectionId?: string) => {
-    const colId = collectionId || mockCollection.collectionId;
+  const renderCollectionDetails = async () => {
     const collectionData: CollectionHit = formatSearchHit(mockResult.results[2].hits[0]) as CollectionHit;
     const library = mockContentLibrary.libraryData;
 
@@ -107,7 +55,8 @@ describe('<CollectionDetails />', () => {
 
     // Collection Description
     expect(screen.getByText('Description / Card Preview Text')).toBeInTheDocument();
-    expect(screen.getByText(mockCollection.description)).toBeInTheDocument();
+    const { description } = mockResult.results[2].hits[0];
+    expect(screen.getByText(description)).toBeInTheDocument();
 
     // Collection History
     expect(screen.getByText('Collection History')).toBeInTheDocument();
@@ -138,7 +87,7 @@ describe('<CollectionDetails />', () => {
     const mockResultCopy = cloneDeep(mockResult);
     mockResultCopy.results[1].facetDistribution.block_type = {};
     mockSearchResult(mockResultCopy);
-    await renderCollectionDetails(mockCollection.collectionNoComponents);
+    await renderCollectionDetails();
 
     expect(screen.getByText('Collection Stats')).toBeInTheDocument();
     expect(await screen.findByText('This collection is currently empty.')).toBeInTheDocument();
@@ -161,7 +110,7 @@ describe('<CollectionDetails />', () => {
       choiceresponse: 12,
     };
     mockSearchResult(mockResultCopy);
-    await renderCollectionDetails(mockCollection.collectionMultipleComponents);
+    await renderCollectionDetails();
 
     expect(screen.getByText('Collection Stats')).toBeInTheDocument();
     expect(await screen.findByText('78')).toBeInTheDocument();