Skip to content

Commit 5825dd3

Browse files
authored
Merge pull request #487 from open-craft/braden/fix-extra-scss
fix: don't accidentally bundle paragon CSS x2
2 parents 3dfc579 + 28c7b32 commit 5825dd3

File tree

2 files changed

+8
-2
lines changed
  • src/editors/containers
    • VideoEditor/components/VideoSettingsModal/components/DurationWidget
    • VideoUploadEditor

2 files changed

+8
-2
lines changed

src/editors/containers/VideoEditor/components/VideoSettingsModal/components/DurationWidget/index.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
@import "@openedx/paragon/scss/core/core";
1+
// do NOT @import "@openedx/paragon/scss/core/core"; in any files in this repo, or it will add 400 kB of extra CSS
2+
// to the MFE each time you do so. The following are OK because they are only defining variables like $grey-500:
3+
@import "@edx/brand/paragon/variables";
4+
@import "@openedx/paragon/scss/core/_variables";
25

36
.total-label {
47
border: 1px solid $gray-500;

src/editors/containers/VideoUploadEditor/index.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
@import "@openedx/paragon/scss/core/core";
1+
// do NOT @import "@openedx/paragon/scss/core/core"; in any files in this repo, or it will add 400 kB of extra CSS
2+
// to the MFE each time you do so. The following are OK because they are only defining variables like $grey-500:
3+
@import "@edx/brand/paragon/variables";
4+
@import "@openedx/paragon/scss/core/_variables";
25

36
.dropzone-middle {
47
border: 2px dashed #ccc;

0 commit comments

Comments
 (0)