Skip to content

Commit 6b57ce3

Browse files
PKulkoRaccoonGangarbrandes
authored andcommitted
refactor: refactoring after review
1 parent 6aff1c1 commit 6b57ce3

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

src/course-unit/CourseUnit.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const CourseUnit = ({ courseId }) => {
2929
unitTitle,
3030
isQueryPending,
3131
savingStatus,
32-
isEditTitleFormOpen,
32+
isTitleEditFormOpen,
3333
isErrorAlert,
3434
isInternetConnectionAlertFailed,
3535
handleTitleEditSubmit,
@@ -62,7 +62,7 @@ const CourseUnit = ({ courseId }) => {
6262
title={(
6363
<HeaderTitle
6464
unitTitle={unitTitle}
65-
isEditTitleFormOpen={isEditTitleFormOpen}
65+
isTitleEditFormOpen={isTitleEditFormOpen}
6666
handleTitleEdit={handleTitleEdit}
6767
handleTitleEditSubmit={handleTitleEditSubmit}
6868
/>

src/course-unit/data/slice.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const slice = createSlice({
88
initialState: {
99
savingStatus: '',
1010
isQueryPending: false,
11-
isEditTitleFormOpen: false,
11+
isTitleEditFormOpen: false,
1212
loadingStatus: {
1313
fetchUnitLoadingStatus: RequestStatus.IN_PROGRESS,
1414
courseSectionVerticalLoadingStatus: RequestStatus.IN_PROGRESS,
@@ -30,7 +30,7 @@ const slice = createSlice({
3030
state.isQueryPending = payload;
3131
},
3232
changeEditTitleFormOpen: (state, { payload }) => {
33-
state.isEditTitleFormOpen = payload;
33+
state.isTitleEditFormOpen = payload;
3434
},
3535
updateSavingStatus: (state, { payload }) => {
3636
state.savingStatus = payload.status;

src/course-unit/header-title/HeaderTitle.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import messages from './messages';
1313

1414
const HeaderTitle = ({
1515
unitTitle,
16-
isEditTitleFormOpen,
16+
isTitleEditFormOpen,
1717
handleTitleEdit,
1818
handleTitleEditSubmit,
1919
}) => {
@@ -28,7 +28,7 @@ const HeaderTitle = ({
2828

2929
return (
3030
<div className="d-flex align-items-center lead">
31-
{isEditTitleFormOpen ? (
31+
{isTitleEditFormOpen ? (
3232
<Form.Group className="m-0">
3333
<Form.Control
3434
ref={(e) => e && e.focus()}
@@ -63,7 +63,7 @@ const HeaderTitle = ({
6363

6464
HeaderTitle.propTypes = {
6565
unitTitle: PropTypes.string.isRequired,
66-
isEditTitleFormOpen: PropTypes.bool.isRequired,
66+
isTitleEditFormOpen: PropTypes.bool.isRequired,
6767
handleTitleEdit: PropTypes.func.isRequired,
6868
handleTitleEditSubmit: PropTypes.func.isRequired,
6969
};

src/course-unit/header-title/HeaderTitle.test.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import HeaderTitle from './HeaderTitle';
99
import messages from './messages';
1010

1111
const unitTitle = 'Getting Started';
12-
const isEditTitleFormOpen = false;
12+
const isTitleEditFormOpen = false;
1313
const handleTitleEdit = jest.fn();
1414
const handleTitleEditSubmit = jest.fn();
1515
let store;
@@ -19,7 +19,7 @@ const renderComponent = (props) => render(
1919
<IntlProvider locale="en">
2020
<HeaderTitle
2121
unitTitle={unitTitle}
22-
isEditTitleFormOpen={isEditTitleFormOpen}
22+
isTitleEditFormOpen={isTitleEditFormOpen}
2323
handleTitleEdit={handleTitleEdit}
2424
handleTitleEditSubmit={handleTitleEditSubmit}
2525
{...props}
@@ -52,7 +52,7 @@ describe('<HeaderTitle />', () => {
5252

5353
it('render HeaderTitle with open edit form', () => {
5454
const { getByRole } = renderComponent({
55-
isEditTitleFormOpen: true,
55+
isTitleEditFormOpen: true,
5656
});
5757

5858
expect(getByRole('textbox', { name: messages.ariaLabelButtonEdit.defaultMessage })).toBeInTheDocument();
@@ -71,7 +71,7 @@ describe('<HeaderTitle />', () => {
7171

7272
it('calls saving title by clicking outside or press Enter key', async () => {
7373
const { getByRole } = renderComponent({
74-
isEditTitleFormOpen: true,
74+
isTitleEditFormOpen: true,
7575
});
7676

7777
const titleField = getByRole('textbox', { name: messages.ariaLabelButtonEdit.defaultMessage });

src/course-unit/hooks.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const useCourseUnit = ({ courseId, blockId }) => {
2929
const loadingStatus = useSelector(getLoadingStatus);
3030
const { draftPreviewLink, publishedPreviewLink } = useSelector(getCourseSectionVertical);
3131
const navigate = useNavigate();
32-
const isEditTitleFormOpen = useSelector(state => state.courseUnit.isEditTitleFormOpen);
32+
const isTitleEditFormOpen = useSelector(state => state.courseUnit.isTitleEditFormOpen);
3333
const isQueryPending = useSelector(state => state.courseUnit.isQueryPending);
3434

3535
const unitTitle = courseUnit.metadata?.displayName || '';
@@ -49,7 +49,7 @@ export const useCourseUnit = ({ courseId, blockId }) => {
4949
};
5050

5151
const handleTitleEdit = () => {
52-
dispatch(changeEditTitleFormOpen(!isEditTitleFormOpen));
52+
dispatch(changeEditTitleFormOpen(!isTitleEditFormOpen));
5353
};
5454

5555
const handleTitleEditSubmit = (displayName) => {
@@ -95,7 +95,7 @@ export const useCourseUnit = ({ courseId, blockId }) => {
9595
isErrorAlert,
9696
isLoading: loadingStatus.fetchUnitLoadingStatus === RequestStatus.IN_PROGRESS
9797
|| loadingStatus.courseSectionVerticalLoadingStatus === RequestStatus.IN_PROGRESS,
98-
isEditTitleFormOpen,
98+
isTitleEditFormOpen,
9999
isInternetConnectionAlertFailed: savingStatus === RequestStatus.FAILED,
100100
handleInternetConnectionFailed,
101101
headerNavigationsActions,

0 commit comments

Comments
 (0)