chore: fix various eslint warnings

Author: bradenmacdonald

.eslintrc.js

@@ -1,3 +1,4 @@
+const path = require('path');
 // eslint-disable-next-line import/no-extraneous-dependencies
 const { createConfig } = require('@edx/frontend-build');
 
@@ -13,5 +14,21 @@ module.exports = createConfig(
       indent: ['error', 2],
       'no-restricted-exports': 'off',
     },
+    settings: {
+      // Import URLs should be resolved using aliases
+      'import/resolver': {
+        webpack: {
+          config: path.resolve(__dirname, 'webpack.dev.config.js'),
+        },
+      },
+    },
+    overrides: [
+      {
+        files: ['plugins/**/*.test.jsx', 'some-other-repo/plugins/**/*.test.jsx'],
+        rules: {
+          'import/no-extraneous-dependencies': 'off',
+        },
+      },
+    ],
   },
 );

package-lock.json

@@ -60,6 +60,7 @@
     "classnames": "2.2.6",
     "core-js": "3.8.1",
     "email-validator": "2.0.4",
+    "eslint-import-resolver-webpack": "^0.13.8",
     "file-saver": "^2.0.5",
     "formik": "2.2.6",
     "jszip": "^3.10.1",

package.json

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 
 import { useIntl } from '@edx/frontend-platform/i18n';
 
@@ -7,8 +8,7 @@ import messages from './messages';
 
 /**
  * Settings widget for the "calculator" Course App.
- * @param {{onClose: () => void}} props 
- * @returns 
+ * @param {{onClose: () => void}} props
  */
 const CalculatorSettings = ({ onClose }) => {
   const intl = useIntl();
@@ -24,4 +24,8 @@ const CalculatorSettings = ({ onClose }) => {
   );
 };
 
+CalculatorSettings.propTypes = {
+  onClose: PropTypes.func.isRequired,
+};
+
 export default CalculatorSettings;

plugins/course-apps/calculator/Settings.jsx

@@ -1,5 +1,12 @@
 {
     "name": "@openedx-plugins/course-app-calculator",
     "version": "0.1.0",
-    "description": "Calculator configuration for courses using it"
+    "description": "Calculator configuration for courses using it",
+    "peerDependencies": {
+        "@edx/frontend-app-course-authoring": "*",
+        "@edx/frontend-platform": "*",
+        "@edx/paragon": "*",
+        "prop-types": "*",
+        "react": "*"
+    }
 }

plugins/course-apps/calculator/package.json

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 
 import { useIntl } from '@edx/frontend-platform/i18n';
 
@@ -7,8 +8,7 @@ import messages from './messages';
 
 /**
  * Settings widget for the "edxnotes" Course App.
- * @param {{onClose: () => void}} props 
- * @returns 
+ * @param {{onClose: () => void}} props
  */
 const NotesSettings = ({ onClose }) => {
   const intl = useIntl();
@@ -21,7 +21,11 @@ const NotesSettings = ({ onClose }) => {
       learnMoreText={intl.formatMessage(messages.enableNotesLink)}
       onClose={onClose}
     />
-    );
-  };
-  
-  export default NotesSettings;
+  );
+};
+
+NotesSettings.propTypes = {
+  onClose: PropTypes.func.isRequired,
+};
+
+export default NotesSettings;

plugins/course-apps/edxnotes/Settings.jsx

@@ -1,5 +1,12 @@
 {
     "name": "@openedx-plugins/course-app-edxnotes",
     "version": "0.1.0",
-    "description": "edxnotes configuration for courses using it"
+    "description": "edxnotes configuration for courses using it",
+    "peerDependencies": {
+        "@edx/frontend-app-course-authoring": "*",
+        "@edx/frontend-platform": "*",
+        "@edx/paragon": "*",
+        "prop-types": "*",
+        "react": "*"
+    }
 }

plugins/course-apps/edxnotes/package.json

@@ -3,12 +3,13 @@ import { getConfig } from '@edx/frontend-platform';
 import { FormattedMessage, injectIntl, intlShape } from '@edx/frontend-platform/i18n';
 import { Form, Hyperlink } from '@edx/paragon';
 import PropTypes from 'prop-types';
-import messages from './messages';
-import { providerNames, bbbPlanTypes } from './constants';
 import AppConfigFormDivider from 'CourseAuthoring/pages-and-resources/discussions/app-config-form/apps/shared/AppConfigFormDivider';
-import LiveCommonFields from './LiveCommonFields';
 import { useModel } from 'CourseAuthoring/generic/model-store';
 
+import { providerNames, bbbPlanTypes } from './constants';
+import LiveCommonFields from './LiveCommonFields';
+import messages from './messages';
+
 const BbbSettings = ({
   intl,
   values,

plugins/course-apps/live/BBBSettings.jsx

@@ -17,18 +17,18 @@ import { IntlProvider } from '@edx/frontend-platform/i18n';
 import userEvent from '@testing-library/user-event';
 import initializeStore from 'CourseAuthoring/store';
 import { executeThunk } from 'CourseAuthoring/utils';
+import PagesAndResourcesProvider from 'CourseAuthoring/pages-and-resources/PagesAndResourcesProvider';
+
 import LiveSettings from './Settings';
 import {
   generateLiveConfigurationApiResponse,
   courseId,
   initialState,
   configurationProviders,
 } from './factories/mockApiResponses';
-
 import { fetchLiveConfiguration, fetchLiveProviders } from './data/thunks';
 import { providerConfigurationApiUrl, providersApiUrl } from './data/api';
 import messages from './messages';
-import PagesAndResourcesProvider from '../PagesAndResourcesProvider';
 
 let axiosMock;
 let container;

plugins/course-apps/live/BbbSettings.test.jsx

@@ -1,9 +1,10 @@
 import React from 'react';
 import { injectIntl, intlShape } from '@edx/frontend-platform/i18n';
 import PropTypes from 'prop-types';
-import messages from './messages';
 import FormikControl from 'CourseAuthoring/generic/FormikControl';
 
+import messages from './messages';
+
 const LiveCommonFields = ({
   intl,
   values,