Skip to content

Commit efd967a

Browse files
test: replacing shallow snapshots with RTL part 2 (#2267)
1 parent eaba380 commit efd967a

File tree

11 files changed

+14
-248
lines changed

11 files changed

+14
-248
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"stylelint": "stylelint \"plugins/**/*.scss\" \"src/**/*.scss\" \"scss/**/*.scss\" --config .stylelintrc.json",
1616
"lint": "npm run stylelint && fedx-scripts eslint --ext .js --ext .jsx --ext .ts --ext .tsx .",
1717
"lint:fix": "npm run stylelint -- --fix && fedx-scripts eslint --fix --ext .js --ext .jsx --ext .ts --ext .tsx .",
18-
"snapshot": "TZ=UTC fedx-scripts jest --updateSnapshot",
1918
"start": "fedx-scripts webpack-dev-server --progress",
2019
"start:with-theme": "paragon install-theme && npm start && npm install",
2120
"dev": "PUBLIC_PATH=/authoring/ MFE_CONFIG_API_URL='http://localhost:8000/api/mfe_config/v1' fedx-scripts webpack-dev-server --progress --host apps.local.openedx.io",

src/editors/sharedComponents/SelectableBox/tests/SelectableBoxSet.test.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,9 @@ const SelectableRadioSet = (props) => (
4141
describe('<SelectableBox.Set />', () => {
4242
describe('correct rendering', () => {
4343
it('renders without props', () => {
44-
const { container } = render(<SelectableRadioSet name="testName" />);
45-
expect(container).toMatchSnapshot();
44+
render(<SelectableRadioSet name="testName" />);
45+
expect(screen.getAllByRole('button')).toHaveLength(3);
46+
[1, 2, 3].forEach((item) => expect(screen.getByText(`SelectableRadio${item}`)).toBeInTheDocument());
4647
});
4748
it('forwards props', () => {
4849
render((<SelectableRadioSet name="testName" data-testid="test-radio-set-name" />));

src/editors/sharedComponents/SelectableBox/tests/__snapshots__/SelectableBoxSet.test.jsx.snap

Lines changed: 0 additions & 57 deletions
This file was deleted.

src/studio-home/tabs-section/courses-tab/courses-filters/__snapshots__/index.test.jsx.snap

Lines changed: 0 additions & 110 deletions
This file was deleted.

src/studio-home/tabs-section/courses-tab/courses-filters/courses-filter-menu/__snapshots__/index.test.jsx.snap

Lines changed: 0 additions & 21 deletions
This file was deleted.

src/studio-home/tabs-section/courses-tab/courses-filters/courses-filter-menu/index.test.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ describe('CoursesFilterMenu', () => {
5151
});
5252
});
5353

54-
it('snapshot', () => {
54+
it('renders component', () => {
5555
const { container } = renderComponent();
56-
expect(container).toMatchSnapshot();
56+
expect(container.querySelector('.dropdown')).toBeInTheDocument();
5757
});
5858

5959
it('should render without crashing', () => {

src/studio-home/tabs-section/courses-tab/courses-filters/courses-order-filter-menu/__snapshots__/index.test.jsx.snap

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/studio-home/tabs-section/courses-tab/courses-filters/courses-order-filter-menu/index.test.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ describe('CoursesTypesFilterMenu', () => {
4141
});
4242
});
4343

44-
it('snapshot', () => {
45-
const { container } = renderComponent();
46-
expect(container).toMatchSnapshot();
44+
it('renders component', () => {
45+
renderComponent();
46+
expect(screen.getByText('Name A-Z')).toBeInTheDocument();
4747
});
4848

4949
it('should render without crashing', () => {

src/studio-home/tabs-section/courses-tab/courses-filters/courses-types-filter-menu/__snapshots__/index.test.jsx.snap

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/studio-home/tabs-section/courses-tab/courses-filters/courses-types-filter-menu/index.test.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ describe('CoursesTypesFilterMenu', () => {
4242
});
4343
});
4444

45-
it('snapshot', () => {
46-
const { container } = renderComponent();
47-
expect(container).toMatchSnapshot();
45+
it('renders component', () => {
46+
renderComponent();
47+
expect(screen.getByText('All courses')).toBeInTheDocument();
4848
});
4949

5050
it('should render without crashing', () => {

0 commit comments

Comments
 (0)