Skip to content

Commit f3332a2

Browse files
fix: remove old editorContainer (#2268)
1 parent bc11aaf commit f3332a2

File tree

5 files changed

+1
-309
lines changed

5 files changed

+1
-309
lines changed

src/CourseAuthoringRoutes.jsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { PageWrap } from '@edx/frontend-platform/react';
77
import { Textbooks } from './textbooks';
88
import CourseAuthoringPage from './CourseAuthoringPage';
99
import { PagesAndResources } from './pages-and-resources';
10-
import EditorContainer from './editors/EditorContainer';
1110
import VideoSelectorContainer from './selectors/VideoSelectorContainer';
1211
import CustomPages from './custom-pages';
1312
import { FilesPage, VideosPage } from './files-and-videos';
@@ -37,7 +36,7 @@ import { IframeProvider } from './generic/hooks/context/iFrameContext';
3736
*
3837
* /course/:courseId/course-pages
3938
* /course/:courseId/proctored-exam-settings
40-
* /course/:courseId/editor/:blockType/:blockId
39+
* /course/:courseId/course-videos/:blockId
4140
*
4241
* This component and CourseAuthoringPage should maybe be combined once we no longer need to have
4342
* CourseAuthoringPage split out for use in LegacyProctoringRoute. Once that route is removed, we
@@ -93,10 +92,6 @@ const CourseAuthoringRoutes = () => {
9392
path="editor/course-videos/:blockId"
9493
element={<PageWrap><VideoSelectorContainer courseId={courseId} /></PageWrap>}
9594
/>
96-
<Route
97-
path="editor/:blockType/:blockId?"
98-
element={<PageWrap><EditorContainer learningContextId={courseId} /></PageWrap>}
99-
/>
10095
<Route
10196
path="settings/details"
10297
element={<PageWrap><ScheduleAndDetails courseId={courseId} /></PageWrap>}

src/CourseAuthoringRoutes.test.jsx

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66

77
const courseId = 'course-v1:edX+TestX+Test_Course';
88
const pagesAndResourcesMockText = 'Pages And Resources';
9-
const editorContainerMockText = 'Editor Container';
109
const videoSelectorContainerMockText = 'Video Selector Container';
1110
const customPagesMockText = 'Custom Pages';
1211
const mockComponentFn = jest.fn();
@@ -33,10 +32,6 @@ jest.mock('./pages-and-resources/PagesAndResources', () => (props) => {
3332
mockComponentFn(props);
3433
return pagesAndResourcesMockText;
3534
});
36-
jest.mock('./editors/EditorContainer', () => (props) => {
37-
mockComponentFn(props);
38-
return editorContainerMockText;
39-
});
4035
jest.mock('./selectors/VideoSelectorContainer', () => (props) => {
4136
mockComponentFn(props);
4237
return videoSelectorContainerMockText;
@@ -69,22 +64,6 @@ describe('<CourseAuthoringRoutes>', () => {
6964
});
7065
});
7166

72-
it('renders the EditorContainer component when the course editor route is active', async () => {
73-
render(
74-
<CourseAuthoringRoutes />,
75-
{ routerProps: { initialEntries: ['/editor/video/block-id'] } },
76-
);
77-
await waitFor(() => {
78-
expect(screen.queryByText(editorContainerMockText)).toBeInTheDocument();
79-
expect(screen.queryByText(pagesAndResourcesMockText)).not.toBeInTheDocument();
80-
expect(mockComponentFn).toHaveBeenCalledWith(
81-
expect.objectContaining({
82-
learningContextId: courseId,
83-
}),
84-
);
85-
});
86-
});
87-
8867
it('renders the VideoSelectorContainer component when the course videos route is active', async () => {
8968
render(
9069
<CourseAuthoringRoutes />,

src/editors/EditorContainer.test.tsx

Lines changed: 0 additions & 94 deletions
This file was deleted.

src/editors/EditorContainer.tsx

Lines changed: 0 additions & 88 deletions
This file was deleted.

src/editors/example.jsx

Lines changed: 0 additions & 100 deletions
This file was deleted.

0 commit comments

Comments
 (0)