Skip to content

fix: allow configure modal overflow to prevent datepicker clipping#2901

Merged
bradenmacdonald merged 2 commits intoopenedx:masterfrom
mitodl:areeb/10311-allow-configure-modal-overflow
Feb 26, 2026
Merged

fix: allow configure modal overflow to prevent datepicker clipping#2901
bradenmacdonald merged 2 commits intoopenedx:masterfrom
mitodl:areeb/10311-allow-configure-modal-overflow

Conversation

@asajjad2
Copy link
Contributor

What are the relevant tickets?

#10311

Description (What does it do?)

The PR fixes the Release date datepicker being clipped in the section configure modal (three-dot menu → Release date) by enabling overflow on the modal isOverflowVisible={true} so the calendar can extend outside the modal like the timepicker, and by giving the datepicker popper a higher z-index inside the configure modal so the dropdown appears above other content.

Screenshots

Before:

Screenshot 2026-02-24 at 3 21 49 PM

After:

Screenshot 2026-02-24 at 3 40 40 PM

Testing Steps

  1. Open a course in Studio and go to the Course Outline.
  2. Find any section and open the three-dot menu on that section, Select Configure and then Basic tab.
  3. In the modal, focus or click the Release date field (e.g. the one that shows “MM/DD/YYYY” or a date like “01/01/2024”) so the datepicker calendar opens.
  4. Verify that the full calendar is visible: month/year at the top, day-of-week row (Mon, Tue, …), and the grid of dates. Nothing is cut off at the top of the modal.

@openedx-webhooks
Copy link

Thanks for the pull request, @asajjad2!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 24, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 24, 2026
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.28%. Comparing base (b57386b) to head (7583dc8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2901    +/-   ##
========================================
  Coverage   95.28%   95.28%            
========================================
  Files        1334     1334            
  Lines       30615    30615            
  Branches     6706     6914   +208     
========================================
  Hits        29170    29170            
+ Misses       1388     1376    -12     
- Partials       57       69    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Feb 24, 2026
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bradenmacdonald bradenmacdonald merged commit 3599630 into openedx:master Feb 26, 2026
8 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants