feat: Enhance Course Optimizer Page with Previous Run Links and Improved UI #2356
+5,602
−268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
from
36e5e52 to
33fa7c8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2356 +/- ##
==========================================
+ Coverage 94.60% 94.62% +0.02%
==========================================
Files 1179 1179
Lines 25506 26135 +629
Branches 5449 5820 +371
==========================================
+ Hits 24129 24731 +602
- Misses 1314 1333 +19
- Partials 63 71 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Faraz32123
reviewed
Aug 12, 2025
Faraz32123
reviewed
Aug 12, 2025
Faraz32123
reviewed
Aug 12, 2025
src/optimizer-page/scan-results/PreviousRunSectionCollapsible.tsx
Outdated
Show resolved
Hide resolved
Faraz32123
reviewed
Aug 12, 2025
Faraz32123
reviewed
Aug 12, 2025
Faraz32123
reviewed
Aug 12, 2025
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
from
d88d14c to
2b44e8f
Compare
Faraz32123
reviewed
Aug 15, 2025
Faraz32123
reviewed
Aug 15, 2025
Faraz32123
reviewed
Aug 15, 2025
Faraz32123
reviewed
Aug 15, 2025
Faraz32123
reviewed
Aug 15, 2025
Faraz32123
reviewed
Aug 15, 2025
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
2 times, most recently
from
e4b049d to
24befc9
Compare
Faraz32123
reviewed
Aug 18, 2025
Faraz32123
reviewed
Aug 18, 2025
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
from
24befc9 to
1dbf10e
Compare
Faraz32123
reviewed
Aug 19, 2025
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
from
2a94dac to
f1646bb
Compare
Faraz32123
requested changes
Aug 28, 2025
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
3 times, most recently
from
47d69b6 to
c6fbd3d
Compare
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
from
c6fbd3d to
5e47e9d
Compare
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
from
6e7ed57 to
2b790bc
Compare
smartameer
reviewed
Sep 1, 2025
| courseId: string, | ||
| ) { | ||
| const shouldPoll = rerunLinkUpdateInProgress === true | ||
| || (rerunLinkUpdateResult && rerunLinkUpdateResult.status && rerunLinkUpdateResult.status !== 'Succeeded'); |
There was a problem hiding this comment.
use RERUN_LINK_UPDATE_STATUSES.SUCCEEDED
smartameer
reviewed
Sep 1, 2025
| ) : ( | ||
| <StatefulButton | ||
| className="px-4 rounded-0 update-link-btn" | ||
| labels={{ default: 'Update', pending: 'Update' }} |
There was a problem hiding this comment.
both labels are same & translation missing?
There was a problem hiding this comment.
yeah, we have only 2 states for this features, update or updated.
And StatefulButton will have same state for default and pending state.
There was a problem hiding this comment.
May be we can move it to constants file.
There was a problem hiding this comment.
@pganesh-apphelix can we also add translation for this update state as well.
smartameer
reviewed
Sep 1, 2025
| <span | ||
| className="updated-link-text d-flex align-items-center text-success" | ||
| > | ||
| Updated |
smartameer
reviewed
Sep 1, 2025
| @@ -89,15 +160,65 @@ type TableData = { | |||
| const BrokenLinkTable: FC<BrokenLinkTableProps> = ({ | |||
| unit, | |||
| filters, | |||
| linkType = 'broken', | |||
smartameer
reviewed
Sep 1, 2025
| } else { | ||
| blocksWithResults.add(result.id); | ||
| } | ||
| }); |
There was a problem hiding this comment.
const typeToSection = {
course_updates: 'course-updates',
custom_pages: 'custom-pages'
}; // to be maintained in constant
const addBlocksWithPrevLinks = sectionId => {
const section = allSections.find(s => s.id === sectionId);
if (!section) return;
section.subsections.forEach(sub =>
sub.units.forEach(unit =>
unit.blocks.forEach(b => {
if (b.previousRunLinks && b.previousRunLinks.length) blocksWithResults.add(b.id);
})
)
);
};
response.results.forEach(result => {
const sectionId = typeToSection[result.type];
if (sectionId) {
addBlocksWithPrevLinks(sectionId);
} else {
blocksWithResults.add(result.id);
}
});
is it ok to write like this to reuse code
pganesh-apphelix
force-pushed
the
pganesh/TNL2-141
branch
from
c42e91a to
aef4ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces multiple UI enhancements and new functionality for the Course Optimizer page. The key updates include:
Previous Run Link Section
contentstore.enable_course_optimizer_check_prev_run_linksCourse Update, Handouts, and Custom Page Section
UI Enhancements
Updated UI for the following elements:
Applied consistent styling based on the new design specifications.
Added functionality:
19-53-40.mp4
Jira
Testing Instructions
Please verify the following: