refactor: Replace of injectIntl with useIntl() part 8 #2288 #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/#2288
branch
from
011c92a to
7f64988
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2357 +/- ##
==========================================
+ Coverage 94.44% 94.51% +0.06%
==========================================
Files 1169 1171 +2
Lines 25102 25158 +56
Branches 5473 5375 -98
==========================================
+ Hits 23708 23777 +69
+ Misses 1328 1318 -10
+ Partials 66 63 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jacobo-dominguez-wgu @bradenmacdonald I have refactored the components but facing code coverage issue for the code which I did not touch what should we do in this case? |
|
@ahtesham-quraish Sorry for the delayed reply. It would be ideal if you can find a way to update the tests to cover those lines, but if not then just ignore them using the directive I mentioned at #2358 (comment) |
ahtesham-quraish
force-pushed
the
ahtesham/#2288
branch
from
7f64988 to
b273094
Compare
|
@bradenmacdonald you can merge this PR. Thanks |
bradenmacdonald
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace of injectIntl with useIntl() part 8 #2288 #2357
Supporting information
Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for manually testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'