Conversation
|
Thanks for the pull request, @regisb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
We replace a dirty hack by a call to the raw-loader from Webpack. This in turns allow us to build this MFE with rsbuild. We emulated the behaviour from frontend-app-discussions: openedx/frontend-app-discussions#27
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 47 47
Lines 695 695
Branches 133 133
=======================================
Hits 584 584
Misses 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
Hi @regisb! Is this still in progress? |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Closing for now due to inactivity. Can reopen if needed. |
We replace a dirty hack by a call to the raw-loader from Webpack. This in turns allow us to build this MFE with rsbuild. We emulated the behaviour from frontend-app-discussions: openedx/frontend-app-discussions#27