Skip to content

Commit 3542c38

Browse files
fix: incorrect usage of header elements
1 parent 14c03d8 commit 3542c38

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

src/containers/CoursesPanel/NoCoursesView/index.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ export const NoCoursesView = () => {
1919
className="d-flex align-items-center justify-content-center mb-4.5"
2020
>
2121
<Image src={emptyCourseSVG} alt={formatMessage(messages.bannerAlt)} />
22-
<h1>
22+
<h3 className="h1">
2323
{formatMessage(messages.lookingForChallengePrompt)}
24-
</h1>
24+
</h3>
2525
<p>
2626
{formatMessage(messages.exploreCoursesPrompt)}
2727
</p>

src/containers/Dashboard/DashboardLayout.jsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ export const DashboardLayout = ({ children }) => {
4040
<Col {...courseListColumnProps} className="course-list-column">
4141
{children}
4242
</Col>
43-
<Col {...columnConfig.sidebar} className="sidebar-column">
44-
{!isCollapsed && (<h2 className="course-list-title">&nbsp;</h2>)}
43+
<Col {...columnConfig.sidebar} className={['sidebar-column', !isCollapsed && 'not-collapsed']}>
4544
<WidgetSidebarSlot />
4645
</Col>
4746
</Row>

src/containers/Dashboard/index.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@
66

77
.sidebar-column {
88
padding: 0 map-get($spacers, 3) 0 map-get($spacers, 1);
9+
10+
&.not-collapsed {
11+
padding-top: map-get($spacers, 2);
12+
13+
& >:first-child {
14+
margin-top: map-get($spacers, 5\.5);
15+
}
16+
}
917
}
1018

1119
@include media-breakpoint-down(lg) {

src/containers/LearnerDashboardHeader/ConfirmEmailBanner/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export const ConfirmEmailBanner = () => {
6464
</Button>
6565
)}
6666
>
67-
<h1 className="text-center p-3">{formatMessage(messages.confirmEmailModalHeader)}</h1>
67+
<h4 className="text-center p-3 h1">{formatMessage(messages.confirmEmailModalHeader)}</h4>
6868
<p className="text-center">{formatMessage(messages.confirmEmailModalBody)}</p>
6969
</MarketingModal>
7070
</>

0 commit comments

Comments
 (0)